Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 1824173002: Fix blank xfa rendering broken at f89acbc. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix blank xfa rendering broken at f89acbc. One initializer was lost in that conversion. R=weili@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/34cc08341b5712c17b504a55aa090eaa59051890

Patch Set 1 #

Patch Set 2 : regenerate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M xfa/fxgraphics/cfx_graphics.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Wei, please review. Looks like we both missed this when looking at the referenced CL. ...
4 years, 9 months ago (2016-03-22 21:19:56 UTC) #3
Wei Li
LGTM, thanks!
4 years, 9 months ago (2016-03-22 21:30:44 UTC) #4
Tom Sepez
4 years, 9 months ago (2016-03-22 21:40:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
34cc08341b5712c17b504a55aa090eaa59051890 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698