Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Unified Diff: android_webview/renderer/aw_content_renderer_client.cc

Issue 1824143004: Allow WebView to force MediaPlayer for unsupported containers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't concat strings. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/renderer/aw_content_renderer_client.h ('k') | android_webview/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/renderer/aw_content_renderer_client.cc
diff --git a/android_webview/renderer/aw_content_renderer_client.cc b/android_webview/renderer/aw_content_renderer_client.cc
index 0ea5facd35419111007e30fc516e90be48caca32..cee6556bd62904e994aac06155de991be06e2859 100644
--- a/android_webview/renderer/aw_content_renderer_client.cc
+++ b/android_webview/renderer/aw_content_renderer_client.cc
@@ -228,6 +228,29 @@ void AwContentRendererClient::AddKeySystems(
AwAddKeySystems(key_systems);
}
+bool AwContentRendererClient::ShouldUseMediaPlayerForURL(const GURL& url) {
+ // Android WebView needs to support codecs that Chrome does not, for these
+ // cases we must force the usage of Android MediaPlayer instead of Chrome's
+ // internal player.
+ //
+ // Note: Despite these extensions being forwarded for playback to MediaPlayer,
+ // HTMLMediaElement.canPlayType() will return empty for these containers.
+ // TODO(boliu): If this is important, extend media::MimeUtil for WebView.
+ //
+ // Format list mirrors:
+ // http://developer.android.com/guide/appendix/media-formats.html
+ static const char* kMediaPlayerExtensions[] = {
+ ".3gp", ".ts", ".flac", ".mid", ".xmf",
+ ".mxmf", ".rtttl", ".rtx", ".ota", ".imy"};
+ for (const auto& extension : kMediaPlayerExtensions) {
+ if (base::EndsWith(url.path(), extension,
+ base::CompareCase::INSENSITIVE_ASCII)) {
+ return true;
+ }
+ }
+ return false;
+}
+
bool AwContentRendererClient::ShouldOverridePageVisibilityState(
const content::RenderFrame* render_frame,
blink::WebPageVisibilityState* override_state) {
« no previous file with comments | « android_webview/renderer/aw_content_renderer_client.h ('k') | android_webview/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698