Source/core/rendering/RenderListItem.cpp - Issue 182413005: Return refererence from InlineBox::root()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderListItem.cpp

Issue 182413005: Return refererence from InlineBox::root() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: re-upload because previous patch didn't upload correctly. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderListItem.cpp

diff --git a/Source/core/rendering/RenderListItem.cpp b/Source/core/rendering/RenderListItem.cpp

index 0ad3ca5970f174d185a783b187b2818658815127..52e184004d29ac0246e0bd66aa47344e3c5653e0 100644

--- a/Source/core/rendering/RenderListItem.cpp

+++ b/Source/core/rendering/RenderListItem.cpp

@@ -349,12 +349,11 @@ void RenderListItem::positionListMarker()

bool adjustOverflow = false;

LayoutUnit markerLogicalLeft;

- RootInlineBox* root = m_marker->inlineBoxWrapper()->root();

+ RootInlineBox& root = m_marker->inlineBoxWrapper()->root();

bool hitSelfPaintingLayer = false;

- RootInlineBox* rootBox = m_marker->inlineBoxWrapper()->root();

- LayoutUnit lineTop = rootBox->lineTop();

- LayoutUnit lineBottom = rootBox->lineBottom();

+ LayoutUnit lineTop = root.lineTop();

+ LayoutUnit lineBottom = root.lineBottom();

// FIXME: Need to account for relative positioning in the layout overflow.

if (style()->isLeftToRightDirection()) {