Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1824123002: Fix borrowed GrVkImage::Resource. (Closed)

Created:
4 years, 9 months ago by jvanverth1
Modified:
4 years, 9 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix borrowed GrVkImage::Resource. With the current system, if we wrap a given GrVkTextureInfo*, add a command using it to the command buffer, then delete the texture, the command buffer will unref the GrVkImage::Resource when it's done, which will delete the VkImage and VkDeviceMemory. This subclasses GrVkImage::Resource for those cases, and will not delete the data on an unref. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1824123002 Committed: https://skia.googlesource.com/skia/+/fe170d28d722f29ada5f1e2c6069e7d24e6a4b84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M src/gpu/vk/GrVkImage.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkImage.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkRenderTarget.cpp View 2 chunks +7 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkTexture.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkTextureRenderTarget.cpp View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jvanverth1
4 years, 9 months ago (2016-03-22 20:00:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824123002/1
4 years, 9 months ago (2016-03-22 20:00:36 UTC) #5
egdaniel
lgtm
4 years, 9 months ago (2016-03-22 20:02:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824123002/1
4 years, 9 months ago (2016-03-22 20:05:18 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 20:16:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fe170d28d722f29ada5f1e2c6069e7d24e6a4b84

Powered by Google App Engine
This is Rietveld 408576698