Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1824053002: Some build file cleanup (Closed)

Created:
4 years, 9 months ago by zra
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Deps in new root certs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -38 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/io_impl_sources.gypi View 1 chunk +0 lines, -34 lines 0 comments Download
M runtime/bin/io_service.cc View 2 chunks +6 lines, -1 line 0 comments Download
M runtime/bin/io_service_no_ssl.cc View 2 chunks +6 lines, -1 line 0 comments Download
M runtime/bin/root_certificates_unsupported.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/bin/secure_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/secure_socket_boringssl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/bin/secure_socket_macos.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/bin/secure_socket_unsupported.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zra
This depends on this pull request landing: https://github.com/dart-lang/root_certificates/pull/1
4 years, 9 months ago (2016-03-22 19:15:33 UTC) #2
zra
PTAL This will also fix the test breakage on the windows bots.
4 years, 9 months ago (2016-03-22 19:45:30 UTC) #3
Ivan Posva
LGTM -ip
4 years, 9 months ago (2016-03-22 20:19:49 UTC) #4
zra
Committed patchset #2 (id:20001) manually as b10f3e7be98445981c890ff6c0cd8e529c2054ea (presubmit successful).
4 years, 9 months ago (2016-03-22 20:29:30 UTC) #6
Alan Knight
4 years, 9 months ago (2016-03-23 00:02:33 UTC) #8
Message was sent while issue was closed.
This breaks Dartium.

Powered by Google App Engine
This is Rietveld 408576698