runtime/vm/intermediate_language_arm64.cc - Issue 1824023002: VM: Fix a couple of issues in the AOT optimizer, add fast path smi multiply.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_arm64.cc

Issue 1824023002: VM: Fix a couple of issues in the AOT optimizer, add fast path smi multiply. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: updated inlining of numeric operators Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_arm64.cc

diff --git a/runtime/vm/intermediate_language_arm64.cc b/runtime/vm/intermediate_language_arm64.cc

index 325b694135eefa9361357f5a8b5ee2cb5ad4ecc1..239ad0b23fba744cf890c41fc9c92af3aa4c79dc 100644

--- a/runtime/vm/intermediate_language_arm64.cc

+++ b/runtime/vm/intermediate_language_arm64.cc

@@ -2834,6 +2834,14 @@ void CheckedSmiOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

__ subs(result, left, Operand(right));

__ b(slow_path->entry_label(), VS);

break;

+ case Token::kMUL:

+ __ SmiUntag(TMP, left);

+ __ mul(result, TMP, right);

+ __ smulh(TMP, TMP, right);

+ // TMP: result bits 64..127.

+ __ cmp(TMP, Operand(result, ASR, 63));

+ __ b(slow_path->entry_label(), NE);

+ break;

case Token::kBIT_OR:

// Operation may be part of combined smi check.

if (!combined_smi_check) {

« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »