Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 1824023002: VM: Fix a couple of issues in the AOT optimizer, add fast path smi multiply. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_arm.cc
diff --git a/runtime/vm/intermediate_language_arm.cc b/runtime/vm/intermediate_language_arm.cc
index 6b180bd47e97a2cca9ed5e5717431abe8ee1a58c..a2c6b9797eea130a8d7f2cd0bd3e63cc5670a48b 100644
--- a/runtime/vm/intermediate_language_arm.cc
+++ b/runtime/vm/intermediate_language_arm.cc
@@ -3105,6 +3105,13 @@ void CheckedSmiOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ subs(result, left, Operand(right));
__ b(slow_path->entry_label(), VS);
break;
+ case Token::kMUL:
+ __ SmiUntag(IP, left);
+ __ smull(result, IP, IP, right);
+ // IP: result bits 32..63.
+ __ cmp(IP, Operand(result, ASR, 31));
+ __ b(slow_path->entry_label(), NE);
+ break;
case Token::kBIT_OR:
// Operation part of combined smi check.
break;

Powered by Google App Engine
This is Rietveld 408576698