Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1823973002: Reenable and adapt long forgotten proxy test. (Closed)

Created:
4 years, 9 months ago by neis
Modified:
4 years, 9 months ago
Reviewers:
rossberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reenable and adapt long forgotten proxy test. R=rossberg BUG= Committed: https://crrev.com/7e3772713f2f253a1cb13ce62763a05953373998 Cr-Commit-Position: refs/heads/master@{#35020}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+598 lines, -736 lines) Patch
M test/mjsunit/es6/proxies-function.js View 1 chunk +598 lines, -736 lines 3 comments Download

Messages

Total messages: 10 (3 generated)
neis
4 years, 9 months ago (2016-03-22 09:44:52 UTC) #1
adamk
lgtm stamp just to have more tests (can't say I read every one in detail, ...
4 years, 9 months ago (2016-03-23 01:37:08 UTC) #3
rossberg
https://codereview.chromium.org/1823973002/diff/1/test/mjsunit/es6/proxies-function.js File test/mjsunit/es6/proxies-function.js (right): https://codereview.chromium.org/1823973002/diff/1/test/mjsunit/es6/proxies-function.js#newcode484 test/mjsunit/es6/proxies-function.js:484: // TODO(rossberg): Ultimately, I want to have the following ...
4 years, 9 months ago (2016-03-23 08:50:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823973002/1
4 years, 9 months ago (2016-03-23 08:55:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 09:14:28 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7e3772713f2f253a1cb13ce62763a05953373998 Cr-Commit-Position: refs/heads/master@{#35020}
4 years, 9 months ago (2016-03-23 09:15:07 UTC) #9
adamk
4 years, 9 months ago (2016-03-23 18:26:11 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1823973002/diff/1/test/mjsunit/es6/proxies-fu...
File test/mjsunit/es6/proxies-function.js (right):

https://codereview.chromium.org/1823973002/diff/1/test/mjsunit/es6/proxies-fu...
test/mjsunit/es6/proxies-function.js:484: // TODO(rossberg): Ultimately, I want
to have the following test function
On 2016/03/23 08:50:11, rossberg wrote:
> On 2016/03/23 01:37:08, adamk wrote:
> > Is it still worth leaving this one in (or, maybe, why is it commented out)?
> 
> Because of what the comment said. ;) At the time it uncovered too many
> pre-existing bugs unrelated to proxies that it was infeasible to fix them all
> immediately. I don't know if that is still the case, it might be worth trying
> again, but that should probably be separated from this test file.
> 
> Of course, there also is the issue that the test has N^6 runtime...

I read the comment, but since it was a carry-over from the old
already-commented-out-test, I was wondering why it didn't get resurrected in
this patch.

Powered by Google App Engine
This is Rietveld 408576698