Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 1823953002: Factor out setIndexedDBClientCreateFunction from blink::initialize (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Factor out setIndexedDBClientCreateFunction from blink::initialize This CL moves setIndexedDBClientCreateFunction to WorkerContentSettingsClient's constructor and WebLocalFrame's constructor. BUG=593269 Committed: https://crrev.com/3056d79df9ba4fe776a42455ebb1f495bd582ad2 Cr-Commit-Position: refs/heads/master@{#382538}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M third_party/WebKit/Source/web/IndexedDBClientImpl.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WorkerContentSettingsClient.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
haraken
PTAL Ideally I want to remove IDBClientImpl, which is used just to overcome the disalllowed ...
4 years, 9 months ago (2016-03-22 06:26:32 UTC) #2
haraken
BTW, this is the final patch of the initialization/shutdown clean-up.
4 years, 9 months ago (2016-03-22 06:26:56 UTC) #3
sof
How about removing IndexedClientImpl entirely and have the indexeddb module do the necessary init (if ...
4 years, 9 months ago (2016-03-22 07:19:53 UTC) #4
haraken
On 2016/03/22 07:19:53, sof wrote: > How about removing IndexedClientImpl entirely and have the indexeddb ...
4 years, 9 months ago (2016-03-22 07:22:47 UTC) #5
sof
Thanks, now I understand the dep. constraint - could you add a comment next to ...
4 years, 9 months ago (2016-03-22 07:46:04 UTC) #6
haraken
On 2016/03/22 07:46:04, sof wrote: > Thanks, now I understand the dep. constraint - could ...
4 years, 9 months ago (2016-03-22 08:33:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823953002/40001
4 years, 9 months ago (2016-03-22 08:33:54 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-22 09:36:40 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3056d79df9ba4fe776a42455ebb1f495bd582ad2 Cr-Commit-Position: refs/heads/master@{#382538}
4 years, 9 months ago (2016-03-22 09:37:58 UTC) #13
haraken
4 years, 8 months ago (2016-03-30 09:34:06 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1847513002/ by haraken@chromium.org.

The reason for reverting is: This caused threading race:

https://bugs.chromium.org/p/chromium/issues/detail?id=599011#c1
.

Powered by Google App Engine
This is Rietveld 408576698