Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1823943002: X87: Extends testb and cmpb/cmpw instruction support in the ia32 assembler. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Extends testb and cmpb/cmpw instruction support in the ia32 assembler. port 22523f25b1f788d331f7b4324889060136170ee1 (r34925) original commit message: This is in preparation for a CL that does the equivalent of http://crrev.com/1780193003 for ia32. BUG= Committed: https://crrev.com/400f6c503803529329a3d0c821cfd85b4f49cc8c Cr-Commit-Position: refs/heads/master@{#34974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -96 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 11 chunks +16 lines, -17 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x87/ic-x87.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M src/regexp/x87/regexp-macro-assembler-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/assembler-x87.h View 4 chunks +14 lines, -5 lines 0 comments Download
M src/x87/assembler-x87.cc View 7 chunks +28 lines, -15 lines 0 comments Download
M src/x87/assembler-x87-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x87/builtins-x87.cc View 7 chunks +15 lines, -9 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 12 chunks +18 lines, -18 lines 0 comments Download
M src/x87/codegen-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/disasm-x87.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 13 chunks +15 lines, -16 lines 0 comments Download
M test/cctest/test-disasm-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-22 04:24:00 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-22 04:55:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823943002/1
4 years, 9 months ago (2016-03-22 04:55:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 05:39:33 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 05:40:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/400f6c503803529329a3d0c821cfd85b4f49cc8c
Cr-Commit-Position: refs/heads/master@{#34974}

Powered by Google App Engine
This is Rietveld 408576698