Allow moving cursors between connected displays.

Allow moving cursors between connected displays.

* Use ComputeBoundary to detect edges instead of using DisplayPlacement.
* This also fixes a bug where wrong key was used when saving preference.

BUG=597274
TEST=covered by unit tests.

Committed: https://crrev.com/77570cbc7acd24938eb6da1bed0d9884f31dcec1
Cr-Commit-Position: refs/heads/master@{#383153}

[oshima, 2016-03-23 12:22:37]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 12:22:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823913002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823913002/120001

[commit-bot: I haz the power, 2016-03-23 12:24:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 12:24:21]

Dry run: Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)

[oshima, 2016-03-23 13:06:40]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 13:06:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823913002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823913002/140001

[oshima, 2016-03-23 13:12:00]

Patchset #1 (id:1) has been deleted

[oshima, 2016-03-23 13:12:08]

Patchset #1 (id:20001) has been deleted

[oshima, 2016-03-23 13:12:09]

Patchset #2 (id:40001) has been deleted

[oshima, 2016-03-23 13:12:13]

Patchset #1 (id:60001) has been deleted

[oshima, 2016-03-23 13:12:18]

Patchset #1 (id:80001) has been deleted

[oshima, 2016-03-23 13:12:23]

Patchset #1 (id:100001) has been deleted

[oshima, 2016-03-23 13:12:27]

Patchset #1 (id:120001) has been deleted

[commit-bot: I haz the power, 2016-03-23 13:48:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 13:48:24]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[oshima, 2016-03-23 14:31:49]

Patchset #2 (id:160001) has been deleted

[oshima, 2016-03-23 14:32:12]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 14:32:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823913002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823913002/180001

[oshima, 2016-03-23 14:38:05]

Description was changed from

==========
3 display mouse

BUG=
==========

to

==========
Allow moving cursors between connected displays.

* Use ComputeBoundary to detect edges instead of using DisplayPlacement.
* This also fixes a bug where wrong key was used when saving preference. 

BUG=597274
TEST=covered by unit tests.
==========

[oshima, 2016-03-23 14:38:05]

oshima@chromium.org changed reviewers:
+ stevenjb@chromium.org

[oshima, 2016-03-23 14:56:25]

Patchset #1 (id:140001) has been deleted

[commit-bot: I haz the power, 2016-03-23 15:13:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 15:13:28]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-03-24 17:33:07]

ping?

[stevenjb, 2016-03-24 18:08:30]

Just comment nits.
LGTM

https://codereview.chromium.org/1823913002/diff/180001/ash/display/display_la...
File ash/display/display_layout_store.cc (right):

https://codereview.chromium.org/1823913002/diff/180001/ash/display/display_la...
ash/display/display_layout_store.cc:53: // A dev/beta channel may have a bad
layout data saved in local state.
nit: s/a bad/bad/

https://codereview.chromium.org/1823913002/diff/180001/ash/display/display_la...
ash/display/display_layout_store.cc:54: // TODO(oshima): Consider removing this
a coulpe of milestones later.
nit: /a couple of milestones later/after M52/ (or 53)

https://codereview.chromium.org/1823913002/diff/180001/ash/display/display_ut...
File ash/display/display_util.h (right):

https://codereview.chromium.org/1823913002/diff/180001/ash/display/display_ut...
ash/display/display_util.h:66: // Returns false if two displays does not
intersect.
nit: s/does not/do not/

https://codereview.chromium.org/1823913002/diff/180001/ash/display/extended_m...
File ash/display/extended_mouse_warp_controller.cc (right):

https://codereview.chromium.org/1823913002/diff/180001/ash/display/extended_m...
ash/display/extended_mouse_warp_controller.cc:108: gfx::Display display =
display_list.back();
Maybe add a comment here? I wrote something similar in JS and still had to read
the code twice to follow it. Something like:

// Remove the last display from the copy of the display list then
// iterate over the remaining displays looking for any adjoining
// warp regions to add.

https://codereview.chromium.org/1823913002/diff/180001/ash/display/extended_m...
File ash/display/extended_mouse_warp_controller.h (right):

https://codereview.chromium.org/1823913002/diff/180001/ash/display/extended_m...
ash/display/extended_mouse_warp_controller.h:109: // |b|.
|drag_source_dispaly_id| is used to indicate in which
nit: |b|. on prev line

[oshima, 2016-03-24 20:37:19]

https://codereview.chromium.org/1823913002/diff/180001/ash/display/display_la...
File ash/display/display_layout_store.cc (right):

https://codereview.chromium.org/1823913002/diff/180001/ash/display/display_la...
ash/display/display_layout_store.cc:53: // A dev/beta channel may have a bad
layout data saved in local state.
On 2016/03/24 18:08:29, stevenjb wrote:
> nit: s/a bad/bad/

Done.

https://codereview.chromium.org/1823913002/diff/180001/ash/display/display_la...
ash/display/display_layout_store.cc:54: // TODO(oshima): Consider removing this
a coulpe of milestones later.
On 2016/03/24 18:08:29, stevenjb wrote:
> nit: /a couple of milestones later/after M52/ (or 53)

Done.

https://codereview.chromium.org/1823913002/diff/180001/ash/display/display_ut...
File ash/display/display_util.h (right):

https://codereview.chromium.org/1823913002/diff/180001/ash/display/display_ut...
ash/display/display_util.h:66: // Returns false if two displays does not
intersect.
On 2016/03/24 18:08:29, stevenjb wrote:
> nit: s/does not/do not/

Done.

https://codereview.chromium.org/1823913002/diff/180001/ash/display/extended_m...
File ash/display/extended_mouse_warp_controller.h (right):

https://codereview.chromium.org/1823913002/diff/180001/ash/display/extended_m...
ash/display/extended_mouse_warp_controller.h:109: // |b|.
|drag_source_dispaly_id| is used to indicate in which
On 2016/03/24 18:08:30, stevenjb wrote:
> nit: |b|. on prev line

Done.

[oshima, 2016-03-24 20:37:42]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2016-03-24 20:38:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823913002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823913002/180001

[commit-bot: I haz the power, 2016-03-24 21:33:31]

Description was changed from

==========
Allow moving cursors between connected displays.

* Use ComputeBoundary to detect edges instead of using DisplayPlacement.
* This also fixes a bug where wrong key was used when saving preference. 

BUG=597274
TEST=covered by unit tests.
==========

to

==========
Allow moving cursors between connected displays.

* Use ComputeBoundary to detect edges instead of using DisplayPlacement.
* This also fixes a bug where wrong key was used when saving preference. 

BUG=597274
TEST=covered by unit tests.
==========

[commit-bot: I haz the power, 2016-03-24 21:33:32]

Committed patchset #1 (id:180001)

[commit-bot: I haz the power, 2016-03-24 21:34:47]

Description was changed from

==========
Allow moving cursors between connected displays.

* Use ComputeBoundary to detect edges instead of using DisplayPlacement.
* This also fixes a bug where wrong key was used when saving preference. 

BUG=597274
TEST=covered by unit tests.
==========

to

==========
Allow moving cursors between connected displays.

* Use ComputeBoundary to detect edges instead of using DisplayPlacement.
* This also fixes a bug where wrong key was used when saving preference.

BUG=597274
TEST=covered by unit tests.

Committed: https://crrev.com/77570cbc7acd24938eb6da1bed0d9884f31dcec1
Cr-Commit-Position: refs/heads/master@{#383153}
==========

[commit-bot: I haz the power, 2016-03-24 21:34:48]

Patchset 1 (id:??) landed as
https://crrev.com/77570cbc7acd24938eb6da1bed0d9884f31dcec1
Cr-Commit-Position: refs/heads/master@{#383153}