Issue 18239002: Remove the "Enable Rich Notifications" flag on ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18239002: Remove the "Enable Rich Notifications" flag on ChromeOS. (Closed)

Created:
7 years, 5 months ago by dewittj

Modified:
7 years, 5 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove the "Enable Rich Notifications" flag on ChromeOS. This removes the about:flags option and always uses rich notifications on ChromeOS. BUG=254719 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209461

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/about_flags.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	ui/message_center/message_center_util.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dewittj

This is the first step. Then we can tear out some code as we find ...

7 years, 5 months ago (2013-06-28 23:01:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/18239002/1

7 years, 5 months ago (2013-06-28 23:17:53 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=171093

7 years, 5 months ago (2013-06-29 04:36:05 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/18239002/1

7 years, 5 months ago (2013-07-01 16:42:28 UTC) #5

Message was sent while issue was closed.

Change committed as 209461

Expand Messages | Collapse Messages