Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1823883002: [DevTools] Removed InjectedScriptHost.eval and InjectedScriptHost.objectForId (Closed)

Created:
4 years, 9 months ago by kozy
Modified:
4 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-get-collection-entries
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Removed InjectedScriptHost.eval and InjectedScriptHost.objectForId BUG=595206 R=dgozman@chromium.org Committed: https://crrev.com/35dec30c38c7a9658696bc86687ee394da810e10 Cr-Commit-Position: refs/heads/master@{#382480}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Messages

Total messages: 9 (3 generated)
kozy
Dmitry, please take a look!
4 years, 9 months ago (2016-03-22 00:07:27 UTC) #1
dgozman
lgtm https://codereview.chromium.org/1823883002/diff/1/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js (left): https://codereview.chromium.org/1823883002/diff/1/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js#oldcode442 third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:442: var objectGroupName = InjectedScriptHost.idToObjectGroupName(parsedObjectId.id); Kill this one as ...
4 years, 9 months ago (2016-03-22 00:51:44 UTC) #2
kozy
all done https://codereview.chromium.org/1823883002/diff/1/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js (left): https://codereview.chromium.org/1823883002/diff/1/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js#oldcode442 third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:442: var objectGroupName = InjectedScriptHost.idToObjectGroupName(parsedObjectId.id); On 2016/03/22 00:51:44, ...
4 years, 9 months ago (2016-03-22 01:07:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823883002/20001
4 years, 9 months ago (2016-03-22 01:09:24 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 02:44:29 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 02:45:42 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/35dec30c38c7a9658696bc86687ee394da810e10
Cr-Commit-Position: refs/heads/master@{#382480}

Powered by Google App Engine
This is Rietveld 408576698