Simplify parsing/loading state, attempt #2

components/test_runner/web_test_proxy.cc

Index: components/test_runner/web_test_proxy.cc
diff --git a/components/test_runner/web_test_proxy.cc b/components/test_runner/web_test_proxy.cc
index 7e76f1f7b9413f4be16c9d54235be439f9790f71..5a163ee8072b2d039376e9b4a76326ce847b7dd7 100644
--- a/components/test_runner/web_test_proxy.cc
+++ b/components/test_runner/web_test_proxy.cc
@@ -964,6 +964,7 @@ bool WebTestProxyBase::DidFailProvisionalLoad(
     blink::WebLocalFrame* frame,
     const blink::WebURLError& error,
     blink::WebHistoryCommitType commit_type) {
+  DCHECK(frame->provisionalDataSource());

[Nate Chapin, 2016/03/22 16:42:43]

Apparently the "return !frame->provisionalDataSource();" below masked the crash
described in crbug.com/594364 in all of our tests. It's intended to catch the
case where CheckDone() synchronously cancels the provisional load and not notify
RenderFrameImpl, since RenderFrameImpl::didFailProvisionalLoad() assumes
frame->provisionalDataSource() is non-null. However, there were a bunch of tests
where frame->provisionalDataSource() was null at the point of this DCHECK, and
if that's the case, we will always crash outside of content_shell.

Unfortunately, we apparently didn't have any non-content_shell tests that
tickled the bug, so it made it to canary before ALL the things started crashing.

   if (test_interfaces_->GetTestRunner()->shouldDumpFrameLoadCallbacks()) {
     PrintFrameDescription(delegate_, frame);
     delegate_->PrintMessage(" - didFailProvisionalLoadWithError\n");