mojo/services/media/common/cpp/circular_buffer_media_pipe_adapter.cc - Issue 1823833003: Take advantage of MojoGetBufferInformation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/media/common/cpp/circular_buffer_media_pipe_adapter.cc

Issue 1823833003: Take advantage of MojoGetBufferInformation (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/dart/packages/mojo_services/lib/mojo/media/media_transport.mojom.dart ('k') | mojo/services/media/common/cpp/mapped_shared_buffer.h » ('j') | services/media/common/media_pipe_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/media/common/cpp/circular_buffer_media_pipe_adapter.cc

diff --git a/mojo/services/media/common/cpp/circular_buffer_media_pipe_adapter.cc b/mojo/services/media/common/cpp/circular_buffer_media_pipe_adapter.cc

index 180577c12682ea878d43a69ee8c74de40cb0ec55..abf23f45d233306b01d51e23008941eab62d6575 100644

--- a/mojo/services/media/common/cpp/circular_buffer_media_pipe_adapter.cc

+++ b/mojo/services/media/common/cpp/circular_buffer_media_pipe_adapter.cc

@@ -115,9 +115,7 @@ void CircularBufferMediaPipeAdapter::Init(uint64_t size) {

return;

}

- // TODO(johngro) : We should not have to send the buffer size, it should be an

- // intrinsic property of the buffer itself and be query-able via the handle.

- pipe_->SetBuffer(duplicated_handle.Pass(), buffer_size_, []() {});

+ pipe_->SetBuffer(duplicated_handle.Pass(), []() {});

}

void CircularBufferMediaPipeAdapter::SetSignalCallback(SignalCbk cbk) {