HttpServerProperties - Implement MRU for AlternateProtocolMap. Persist

net/http/http_server_properties_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_SERVER_PROPERTIES_IMPL_H_
 #define NET_HTTP_HTTP_SERVER_PROPERTIES_IMPL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 13 matching lines @@
 class ListValue;
 }
 
 namespace net {
 
 // The implementation for setting/retrieving the HTTP server properties.
 class NET_EXPORT HttpServerPropertiesImpl
     : public HttpServerProperties,
       NON_EXPORTED_BASE(public base::NonThreadSafe) {
  public:
+  typedef base::MRUCache<
+     HostPortPair, PortAlternateProtocolPair> CachedAlternateProtocolMap;
+
   HttpServerPropertiesImpl();
   virtual ~HttpServerPropertiesImpl();
 
   // Initializes |spdy_servers_table_| with the servers (host/port) from
   // |spdy_servers| that either support SPDY or not.
   void InitializeSpdyServers(std::vector<std::string>* spdy_servers,
                              bool support_spdy);
 
   void InitializeAlternateProtocolServers(
       AlternateProtocolMap* alternate_protocol_servers);
@@ skipping 53 matching lines @@
   // Sets the Alternate-Protocol for |server|.
   virtual void SetAlternateProtocol(
       const HostPortPair& server,
       uint16 alternate_port,
       AlternateProtocol alternate_protocol) OVERRIDE;
 
   // Sets the Alternate-Protocol for |server| to be BROKEN.
   virtual void SetBrokenAlternateProtocol(const HostPortPair& server) OVERRIDE;
 
   // Returns all Alternate-Protocol mappings.
-  virtual const AlternateProtocolMap& alternate_protocol_map() const OVERRIDE;
+  virtual AlternateProtocolMap GetAlternateProtocolMap() const OVERRIDE;
 
   // Gets a reference to the SettingsMap stored for a host.
   // If no settings are stored, returns an empty SettingsMap.
   virtual const SettingsMap& GetSpdySettings(
       const HostPortPair& host_port_pair) const OVERRIDE;
 
   // Saves an individual SPDY setting for a host. Returns true if SPDY setting
   // is to be persisted.
   virtual bool SetSpdySetting(const HostPortPair& host_port_pair,
                               SpdySettingsIds id,
@@ skipping 34 matching lines @@
   typedef base::hash_map<std::string, bool> SpdyServerHostPortTable;
   typedef std::map<HostPortPair, NetworkStats> ServerNetworkStatsMap;
   typedef std::map<HostPortPair, HostPortPair> CanonicalHostMap;
   typedef std::vector<std::string> CanonicalSufficList;
 
   // Return the canonical host for |server|, or end if none exists.
   CanonicalHostMap::const_iterator GetCanonicalHost(HostPortPair server) const;
 
   SpdyServerHostPortTable spdy_servers_table_;
 
-  AlternateProtocolMap alternate_protocol_map_;
+  scoped_ptr<CachedAlternateProtocolMap> alternate_protocol_map_;

[Ryan Hamilton, 2014/03/05 00:19:20]

Is the idea here that the actual map we're keeping is of a different type than
AlternateProtocolMap?

[ramant (doing other things), 2014/03/05 15:11:11]

Used the MRUCache for AlternateProtocolMap. 

Will dig up Pipeline code's review to see why the actual map
CachedPipelineCapabilityMap is different from PipelineCapabilityMap.

   SpdySettingsMap spdy_settings_map_;
   ServerNetworkStatsMap server_network_stats_map_;
   scoped_ptr<CachedPipelineCapabilityMap> pipeline_capability_map_;
   // Contains a map of servers which could share the same alternate protocol.
   // Map from a Canonical host/port (host is some postfix of host names) to an
   // actual origin, which has a plausible alternate protocol mapping.
   CanonicalHostMap canonical_host_to_origin_map_;
   // Contains list of suffixes (for exmaple ".c.youtube.com",
   // ".googlevideo.com") of canoncial hostnames.
   CanonicalSufficList canoncial_suffixes_;
 
   base::WeakPtrFactory<HttpServerPropertiesImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpServerPropertiesImpl);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_SERVER_PROPERTIES_IMPL_H_