Web Animations: Add Interpolation class.

Web Animations: Add Interpolation class.

This patch introduces the Interpolation class, which represents
a primitive animation between two values (expressed as InterpolableValues).

This is part of an effort to refactor the animations pipeline in order
to make it generic on animation value type (see linked master bug).

This code is not yet used anywhere. It will be used in future patches.

BUG=346495
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168629

[alancutter (OOO until 2018), 2014-03-05 04:30:40]

lgtm with nit.

https://codereview.chromium.org/182383011/diff/1/Source/core/animation/Interp...
File Source/core/animation/Interpolation.cpp (right):

https://codereview.chromium.org/182383011/diff/1/Source/core/animation/Interp...
Source/core/animation/Interpolation.cpp:39:
Interpolation::Interpolation(PassOwnPtr<InterpolableValue> start,
PassOwnPtr<InterpolableValue> end)
Constructors are usually at the top of source files where possible.

[Timothy Loh, 2014-03-05 06:09:48]

lgtm

[dstockwell, 2014-03-06 02:12:19]

https://codereview.chromium.org/182383011/diff/1/Source/core/animation/Interp...
File Source/core/animation/Interpolation.cpp (right):

https://codereview.chromium.org/182383011/diff/1/Source/core/animation/Interp...
Source/core/animation/Interpolation.cpp:45: ASSERT(typesMatch(m_start.get(),
m_end.get()));
I thought this was going to be a release assert to make up for not having a
release assert in InterpolableList?

[Timothy Loh, 2014-03-06 02:54:49]

https://codereview.chromium.org/182383011/diff/1/Source/core/animation/Interp...
File Source/core/animation/Interpolation.cpp (right):

https://codereview.chromium.org/182383011/diff/1/Source/core/animation/Interp...
Source/core/animation/Interpolation.cpp:27: const InterpolableList* endList =
toInterpolableList(end);
Probably need to explicitly check for end->isList() here too if we're making the
check a release assert.

[shans, 2014-03-06 04:42:57]

https://codereview.chromium.org/182383011/diff/1/Source/core/animation/Interp...
File Source/core/animation/Interpolation.cpp (right):

https://codereview.chromium.org/182383011/diff/1/Source/core/animation/Interp...
Source/core/animation/Interpolation.cpp:27: const InterpolableList* endList =
toInterpolableList(end);
On 2014/03/06 02:54:49, Timothy Loh wrote:
> Probably need to explicitly check for end->isList() here too if we're making
the
> check a release assert.

Done.

https://codereview.chromium.org/182383011/diff/1/Source/core/animation/Interp...
Source/core/animation/Interpolation.cpp:39:
Interpolation::Interpolation(PassOwnPtr<InterpolableValue> start,
PassOwnPtr<InterpolableValue> end)
On 2014/03/05 04:30:43, alancutter wrote:
> Constructors are usually at the top of source files where possible.

Done.

https://codereview.chromium.org/182383011/diff/1/Source/core/animation/Interp...
Source/core/animation/Interpolation.cpp:45: ASSERT(typesMatch(m_start.get(),
m_end.get()));
On 2014/03/06 02:12:19, dstockwell wrote:
> I thought this was going to be a release assert to make up for not having a
> release assert in InterpolableList?

Done.

[dstockwell, 2014-03-06 10:56:39]

lgtm

[commit-bot: I haz the power, 2014-03-06 10:57:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shans@chromium.org/182383011/20001

[commit-bot: I haz the power, 2014-03-06 12:01:00]

Change committed as 168629