Make the ContentGestureProvider a ui::FilteredGestureProvider

Make the ContentGestureProvider a ui::FilteredGestureProvider

Move the ContentGestureProvider to ui/, allowing the filtering and gesture
batching code to be used outside of content/.  Also eliminate
TouchDispositionGestureFilter's dependency on a custom ack result type,
instead simply using a bool to indicate whether or not the ack'ed touch was
consumed.

BUG=348588
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255190

[jdduke (slow), 2014-03-03 18:52:55]

PTAL.  I'll need to rebase on your changes, but it shouldn't be too bad...

I went ahead and made the bool ack change to TouchDispositionGestureFilter while
I was removing the InputEventAckState dependency that ContentGestureProvider
had... if you prefer I can factor that out into a separate patch.

[tdresser, 2014-03-03 19:44:32]

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
File content/browser/renderer_host/input/web_input_event_util.cc (right):

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
content/browser/renderer_host/input/web_input_event_util.cc:148: WebGestureEvent
CreateWebGestureEventFromGestureEventData(
The type conversion could be factored out of here and
MakeWebGestureEventFromUIEvent in ui_events_helper.cc.

I think that refactoring would be worthwhile, but it is a pretty small win. Up
to you.

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
File content/browser/renderer_host/input/web_input_event_util.h (right):

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
content/browser/renderer_host/input/web_input_event_util.h:27: CONTENT_EXPORT
blink::WebGestureEvent CreateWebGestureEventFromGestureEventData(
Should this go in content/browser/renderer_host/ui_events_helper.*?
Seems to fit a bit better there than here.

https://codereview.chromium.org/182383007/diff/60001/ui/events/gesture_detect...
File ui/events/gesture_detection/touch_disposition_gesture_filter.h (right):

https://codereview.chromium.org/182383007/diff/60001/ui/events/gesture_detect...
ui/events/gesture_detection/touch_disposition_gesture_filter.h:75: //
dispatched, its type will occur in this set. Cleared when a new touch
Update comment. (No longer cleared)

https://codereview.chromium.org/182383007/diff/60001/ui/events/gesture_detect...
ui/events/gesture_detection/touch_disposition_gesture_filter.h:77: BitSet32
last_gesture_of_type_dropped_;
Why does the last_gesture_of_type_dropped_ need to be per sequence?

[jdduke (slow), 2014-03-03 22:33:17]

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
File content/browser/renderer_host/input/web_input_event_util.cc (right):

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
content/browser/renderer_host/input/web_input_event_util.cc:148: WebGestureEvent
CreateWebGestureEventFromGestureEventData(
On 2014/03/03 19:44:32, tdresser wrote:
> The type conversion could be factored out of here and
> MakeWebGestureEventFromUIEvent in ui_events_helper.cc.
> 
> I think that refactoring would be worthwhile, but it is a pretty small win. Up
> to you.

See above.  In general I agree, but that file is only compiled/used on Aura.

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
File content/browser/renderer_host/input/web_input_event_util.h (right):

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
content/browser/renderer_host/input/web_input_event_util.h:27: CONTENT_EXPORT
blink::WebGestureEvent CreateWebGestureEventFromGestureEventData(
On 2014/03/03 19:44:32, tdresser wrote:
> Should this go in content/browser/renderer_host/ui_events_helper.*?
> Seems to fit a bit better there than here.

I believe that has an events target dependency, and is only compiled on Aura.

https://codereview.chromium.org/182383007/diff/60001/ui/events/gesture_detect...
File ui/events/gesture_detection/touch_disposition_gesture_filter.h (right):

https://codereview.chromium.org/182383007/diff/60001/ui/events/gesture_detect...
ui/events/gesture_detection/touch_disposition_gesture_filter.h:75: //
dispatched, its type will occur in this set. Cleared when a new touch
On 2014/03/03 19:44:32, tdresser wrote:
> Update comment. (No longer cleared)

Done.

https://codereview.chromium.org/182383007/diff/60001/ui/events/gesture_detect...
ui/events/gesture_detection/touch_disposition_gesture_filter.h:77: BitSet32
last_gesture_of_type_dropped_;
On 2014/03/03 19:44:32, tdresser wrote:
> Why does the last_gesture_of_type_dropped_ need to be per sequence?

Are you thinking of the double-tap case? I don't see any harm in resetting it
along with the other state tracking bits when a new touch sequence becomes
current.

[tdresser, 2014-03-04 13:48:35]

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
File content/browser/renderer_host/input/web_input_event_util.cc (right):

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
content/browser/renderer_host/input/web_input_event_util.cc:148: WebGestureEvent
CreateWebGestureEventFromGestureEventData(
On 2014/03/03 22:33:17, jdduke wrote:
> On 2014/03/03 19:44:32, tdresser wrote:
> > The type conversion could be factored out of here and
> > MakeWebGestureEventFromUIEvent in ui_events_helper.cc.
> > 
> > I think that refactoring would be worthwhile, but it is a pretty small win.
Up
> > to you.
> 
> See above.  In general I agree, but that file is only compiled/used on Aura.

A new file in events_base which contains some of conversion functions sounds
good to me. I don't really like the name gesture_detection_events_helper, as
some of these methods will also be used in converting from ui::GestureEvents to
WebGestureEvents. What about just gesture_events_helper or
gesture_event_conversions?

https://codereview.chromium.org/182383007/diff/60001/ui/events/gesture_detect...
File ui/events/gesture_detection/touch_disposition_gesture_filter.h (right):

https://codereview.chromium.org/182383007/diff/60001/ui/events/gesture_detect...
ui/events/gesture_detection/touch_disposition_gesture_filter.h:77: BitSet32
last_gesture_of_type_dropped_;
On 2014/03/03 22:33:17, jdduke wrote:
> On 2014/03/03 19:44:32, tdresser wrote:
> > Why does the last_gesture_of_type_dropped_ need to be per sequence?
> 
> Are you thinking of the double-tap case? I don't see any harm in resetting it
> along with the other state tracking bits when a new touch sequence becomes
> current.

You're right, this is fine. I was forgetting that BitSet32 is super light.

[jdduke (slow), 2014-03-04 15:50:13]

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
File content/browser/renderer_host/input/web_input_event_util.cc (right):

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
content/browser/renderer_host/input/web_input_event_util.cc:148: WebGestureEvent
CreateWebGestureEventFromGestureEventData(
On 2014/03/04 13:48:35, tdresser wrote:
> On 2014/03/03 22:33:17, jdduke wrote:
> > On 2014/03/03 19:44:32, tdresser wrote:
> > > The type conversion could be factored out of here and
> > > MakeWebGestureEventFromUIEvent in ui_events_helper.cc.
> > > 
> > > I think that refactoring would be worthwhile, but it is a pretty small
win.
> Up
> > > to you.
> > 
> > See above.  In general I agree, but that file is only compiled/used on Aura.
> 
> A new file in events_base which contains some of conversion functions sounds
> good to me. I don't really like the name gesture_detection_events_helper, as
> some of these methods will also be used in converting from ui::GestureEvents
to
> WebGestureEvents. What about just gesture_events_helper or
> gesture_event_conversions?

Hmm, GestureEventData only exists in gesture_detection, and do we want a
dependency on blink in events_base?

[tdresser, 2014-03-04 16:32:14]

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
File content/browser/renderer_host/input/web_input_event_util.cc (right):

https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
content/browser/renderer_host/input/web_input_event_util.cc:148: WebGestureEvent
CreateWebGestureEventFromGestureEventData(
On 2014/03/04 15:50:14, jdduke wrote:
> On 2014/03/04 13:48:35, tdresser wrote:
> > On 2014/03/03 22:33:17, jdduke wrote:
> > > On 2014/03/03 19:44:32, tdresser wrote:
> > > > The type conversion could be factored out of here and
> > > > MakeWebGestureEventFromUIEvent in ui_events_helper.cc.
> > > > 
> > > > I think that refactoring would be worthwhile, but it is a pretty small
> win.
> > Up
> > > > to you.
> > > 
> > > See above.  In general I agree, but that file is only compiled/used on
Aura.
> > 
> > A new file in events_base which contains some of conversion functions sounds
> > good to me. I don't really like the name gesture_detection_events_helper, as
> > some of these methods will also be used in converting from ui::GestureEvents
> to
> > WebGestureEvents. What about just gesture_events_helper or
> > gesture_event_conversions?
> 
> Hmm, GestureEventData only exists in gesture_detection, and do we want a
> dependency on blink in events_base?

If we thought it was worthwhile, we could at least put the ui::EventType to
WebInputEvent::Type conversion somewhere where both Aura and Clank could access
it.

[tdresser, 2014-03-04 16:50:17]

On 2014/03/04 16:32:14, tdresser wrote:
>
https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
> File content/browser/renderer_host/input/web_input_event_util.cc (right):
> 
>
https://codereview.chromium.org/182383007/diff/60001/content/browser/renderer...
> content/browser/renderer_host/input/web_input_event_util.cc:148:
WebGestureEvent
> CreateWebGestureEventFromGestureEventData(
> On 2014/03/04 15:50:14, jdduke wrote:
> > On 2014/03/04 13:48:35, tdresser wrote:
> > > On 2014/03/03 22:33:17, jdduke wrote:
> > > > On 2014/03/03 19:44:32, tdresser wrote:
> > > > > The type conversion could be factored out of here and
> > > > > MakeWebGestureEventFromUIEvent in ui_events_helper.cc.
> > > > > 
> > > > > I think that refactoring would be worthwhile, but it is a pretty small
> > win.
> > > Up
> > > > > to you.
> > > > 
> > > > See above.  In general I agree, but that file is only compiled/used on
> Aura.
> > > 
> > > A new file in events_base which contains some of conversion functions
sounds
> > > good to me. I don't really like the name gesture_detection_events_helper,
as
> > > some of these methods will also be used in converting from
ui::GestureEvents
> > to
> > > WebGestureEvents. What about just gesture_events_helper or
> > > gesture_event_conversions?
> > 
> > Hmm, GestureEventData only exists in gesture_detection, and do we want a
> > dependency on blink in events_base?
> 
> If we thought it was worthwhile, we could at least put the ui::EventType to
> WebInputEvent::Type conversion somewhere where both Aura and Clank could
access
> it.

As discussed, we can do this refactor once we've gotten rid of GestureEventData.
LGTM.

[jdduke (slow), 2014-03-05 19:35:28]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-03-05 19:36:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/182383007/200001

[commit-bot: I haz the power, 2014-03-05 23:56:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/182383007/200001

[commit-bot: I haz the power, 2014-03-06 01:07:38]

Change committed as 255190