Issue 182383002: Reland "Change FontFallbackWin to use FamilyNameIterator"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 182383002: Reland "Change FontFallbackWin to use FamilyNameIterator" (Closed)

Created:
6 years, 10 months ago by eae

Modified:
6 years, 10 months ago

Reviewers:
bungeman-chromium

CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Reland "Change FontFallbackWin to use FamilyNameIterator" Change the windows font fallback code to use SkTypeface and createFamilyNameIterator to check whether a font exists instead of calling GDI directly. This removes the last use of HFONT for DW builds and supports fonts with locale dependent names. Originally landed in r167917 and reverted in r167937 as it caused crashes due to a missing adoptRef call. This patch includes the missing adoptRef call. BUG=251355 R=bungeman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167985

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -15 lines)			Patch
	M	Source/platform/fonts/win/FontFallbackWin.cpp	View		2 chunks	+18 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/182383002/1

6 years, 10 months ago (2014-02-27 00:50:16 UTC) #4

Message was sent while issue was closed.

Change committed as 167985

Expand Messages | Collapse Messages