Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1823813003: Revert of [es6] Ship new ES6 instanceof operator semantics. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, rossberg, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_instanceof-stub-param
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Ship new ES6 instanceof operator semantics. (patchset #1 id:1 of https://codereview.chromium.org/1820903002/ ) Reason for revert: Breaks two layout tests when rolling into Chromium. Tests needs investigation and most likely a rebaseline. The following are the tests that fail: - imported/web-platform-tests/html/semantics/text-level-semantics/the-time-element/001.html - fast/dom/Window/window-postmessage-clone-deep-array.html https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64/5594/layout-test-results/results.html Original issue's description: > [es6] Ship new ES6 instanceof operator semantics. > > R=hablich@chromium.org > BUG=v8:4447 > LOG=n > > Committed: https://crrev.com/5836807ea89b96ecfb4bbd8febf0d67bb8dae9ed > Cr-Commit-Position: refs/heads/master@{#34984} TBR=hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4447 Committed: https://crrev.com/3521b37df2b24261ae5fb4f73404bdaab2f58009 Cr-Commit-Position: refs/heads/master@{#34995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Created Revert of [es6] Ship new ES6 instanceof operator semantics.
4 years, 9 months ago (2016-03-22 16:04:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823813003/1
4 years, 9 months ago (2016-03-22 16:04:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 16:04:26 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3521b37df2b24261ae5fb4f73404bdaab2f58009 Cr-Commit-Position: refs/heads/master@{#34995}
4 years, 9 months ago (2016-03-22 16:05:00 UTC) #6
Michael Hablich
On 2016/03/22 16:05:00, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 9 months ago (2016-03-22 17:28:30 UTC) #7
Michael Hablich
4 years, 9 months ago (2016-03-22 17:28:31 UTC) #8
Message was sent while issue was closed.
On 2016/03/22 16:05:00, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/3521b37df2b24261ae5fb4f73404bdaab2f58009
> Cr-Commit-Position: refs/heads/master@{#34995}

Thanks for collecting the test results and reverting

lgtm

Powered by Google App Engine
This is Rietveld 408576698