Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: src/heap/mark-compact.h

Issue 1823783003: [heap] RecordWrites iterates black object to ensure marking progress. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/incremental-marking.cc ('k') | src/heap/mark-compact.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/mark-compact.h
diff --git a/src/heap/mark-compact.h b/src/heap/mark-compact.h
index 3bcc0286ef033cb3c397686b317facec25259152..cd207bcda27ba792ec2291abead68006c86932be 100644
--- a/src/heap/mark-compact.h
+++ b/src/heap/mark-compact.h
@@ -370,7 +370,6 @@ class MarkBitCellIterator BASE_EMBEDDED {
enum LiveObjectIterationMode {
kBlackObjects,
kGreyObjects,
- kGreyObjectsOnBlackPage,
kAllLiveObjects
};
@@ -382,10 +381,8 @@ class LiveObjectIterator BASE_EMBEDDED {
it_(chunk_),
cell_base_(it_.CurrentCellBase()),
current_cell_(*it_.CurrentCell()) {
- // Black pages can only be iterated with kGreyObjectsOnBlackPage mode.
- if (T != kGreyObjectsOnBlackPage) {
- DCHECK(!chunk->IsFlagSet(Page::BLACK_PAGE));
- }
+ // Black pages can not be iterated.
+ DCHECK(!chunk->IsFlagSet(Page::BLACK_PAGE));
}
HeapObject* Next();
@@ -709,7 +706,6 @@ class MarkCompactCollector {
// on various pages of the heap. Used by {RefillMarkingDeque} only.
template <class T>
void DiscoverGreyObjectsWithIterator(T* it);
- template <LiveObjectIterationMode T>
void DiscoverGreyObjectsOnPage(MemoryChunk* p);
void DiscoverGreyObjectsInSpace(PagedSpace* space);
void DiscoverGreyObjectsInNewSpace();
« no previous file with comments | « src/heap/incremental-marking.cc ('k') | src/heap/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698