Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 1823783003: [heap] RecordWrites iterates black object to ensure marking progress. (Closed)

Created:
4 years, 9 months ago by Hannes Payer (out of office)
Modified:
4 years, 9 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] RecordWrites iterates black object to ensure marking progress. RecordWrites is not performing black to grey transitions anymore. In a follow up CL I will clean-up the remaining sites where we do black to grey, e.g. when we overflow marking deque. BUG= Committed: https://crrev.com/9b54762809639c62a58f947359badb47d3e952e7 Cr-Commit-Position: refs/heads/master@{#35031}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -92 lines) Patch
M src/heap/heap.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 2 chunks +1 line, -48 lines 0 comments Download
M src/heap/mark-compact.h View 1 2 3 3 chunks +2 lines, -6 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 5 chunks +8 lines, -11 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 2 3 2 chunks +2 lines, -17 lines 0 comments Download
M src/objects.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Hannes Payer (out of office)
4 years, 9 months ago (2016-03-22 13:43:18 UTC) #3
ulan
lgtm
4 years, 9 months ago (2016-03-22 14:01:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823783003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823783003/60001
4 years, 9 months ago (2016-03-23 13:23:37 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-23 14:20:17 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 14:21:05 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9b54762809639c62a58f947359badb47d3e952e7
Cr-Commit-Position: refs/heads/master@{#35031}

Powered by Google App Engine
This is Rietveld 408576698