Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1823773003: CC Animation: Add perf tests for AnimationHost with AnimationTimelines (Closed)

Created:
4 years, 9 months ago by loyso (OOO)
Modified:
4 years, 8 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Add perf tests for AnimationHost with AnimationTimelines These are the perf tests for https://codereview.chromium.org/1814103002 BUG=595584 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/c0605b3e38b266326e405e7fffd7301e1e839fde Cr-Commit-Position: refs/heads/master@{#383623}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rework. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -43 lines) Patch
M cc/animation/animation_host_perftest.cc View 1 2 chunks +84 lines, -43 lines 0 comments Download
M cc/test/fake_layer_tree_host.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
loyso (OOO)
4 years, 9 months ago (2016-03-22 01:05:54 UTC) #4
ajuma
https://codereview.chromium.org/1823773003/diff/1/cc/animation/animation_host_perftest.cc File cc/animation/animation_host_perftest.cc (right): https://codereview.chromium.org/1823773003/diff/1/cc/animation/animation_host_perftest.cc#newcode149 cc/animation/animation_host_perftest.cc:149: "runs/s", true); A couple nits: 1) These two tests ...
4 years, 9 months ago (2016-03-22 13:28:28 UTC) #5
loyso (OOO)
On 2016/03/22 13:28:28, ajuma wrote: > https://codereview.chromium.org/1823773003/diff/1/cc/animation/animation_host_perftest.cc > File cc/animation/animation_host_perftest.cc (right): > > https://codereview.chromium.org/1823773003/diff/1/cc/animation/animation_host_perftest.cc#newcode149 > ...
4 years, 9 months ago (2016-03-24 01:34:58 UTC) #6
ajuma
Thanks, lgtm
4 years, 9 months ago (2016-03-24 13:50:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823773003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823773003/20001
4 years, 8 months ago (2016-03-28 23:05:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 00:09:11 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 00:10:26 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0605b3e38b266326e405e7fffd7301e1e839fde
Cr-Commit-Position: refs/heads/master@{#383623}

Powered by Google App Engine
This is Rietveld 408576698