Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1823763006: Files app: Increase information in details panel. (Closed)

Created:
4 years, 9 months ago by ryoh
Modified:
4 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files app: Increase information in details panel. BUG=274045 Committed: https://crrev.com/b5101ec8c328dea9c88c72f8ee6bd37c478a9eb9 Cr-Commit-Position: refs/heads/master@{#382525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -25 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/single_file_details.js View 3 chunks +26 lines, -25 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ryoh
Hi, in this CL, I added - Image resolution - Media title/artist to details panel ...
4 years, 9 months ago (2016-03-22 05:32:24 UTC) #2
fukino
LGTM!
4 years, 9 months ago (2016-03-22 06:23:35 UTC) #3
ryoh
On 2016/03/22 06:23:35, fukino wrote: > LGTM! Thanks!
4 years, 9 months ago (2016-03-22 06:43:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823763006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823763006/1
4 years, 9 months ago (2016-03-22 06:43:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 07:25:28 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 07:26:59 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b5101ec8c328dea9c88c72f8ee6bd37c478a9eb9
Cr-Commit-Position: refs/heads/master@{#382525}

Powered by Google App Engine
This is Rietveld 408576698