Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 1823763003: Move more files to gpu/ipc/common (Closed)

Created:
4 years, 9 months ago by Fady Samuel
Modified:
4 years, 9 months ago
Reviewers:
dcheng, piman
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mcasas+watch_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more files to gpu/ipc/common This CL moves: content/common/gpu/gpu_memory_uma_stats.h content/common/gpu/gpu_surface_lookup.cc content/common/gpu/gpu_surface_lookup.h to gpu/ipc/common. BUG=596290 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/efd3ce2aac23c08d4b3296a217359af73edc8629 Cr-Commit-Position: refs/heads/master@{#382785}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix gpu_ipc_common.gypi #

Patch Set 4 : Fixed Android Build #

Total comments: 2

Patch Set 5 : Removed gpu_process_launch_causes change #

Patch Set 6 : Rebased #

Patch Set 7 : Cleanup #

Patch Set 8 : Fixed GYP build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -162 lines) Patch
M content/app/android/child_process_service.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_surface_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_surface_tracker.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel_manager_delegate.h View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel_test_common.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_channel_test_common.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_memory_manager.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
D content/common/gpu/gpu_memory_uma_stats.h View 1 chunk +0 lines, -36 lines 0 comments Download
D content/common/gpu/gpu_surface_lookup.h View 1 chunk +0 lines, -40 lines 0 comments Download
D content/common/gpu/gpu_surface_lookup.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M content/common/gpu/image_transport_surface_android.cc View 1 2 3 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/media/android_deferred_rendering_backing_strategy.cc View 1 2 3 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu_host_messages.h View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M gpu/gpu_ipc_common.gypi View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M gpu/ipc/common/BUILD.gn View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
A + gpu/ipc/common/gpu_memory_uma_stats.h View 1 2 3 4 3 chunks +6 lines, -7 lines 0 comments Download
A + gpu/ipc/common/gpu_surface_lookup.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + gpu/ipc/common/gpu_surface_lookup.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 40 (21 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823763003/1
4 years, 9 months ago (2016-03-22 02:42:56 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/200104) mac_chromium_gn_rel on ...
4 years, 9 months ago (2016-03-22 02:44:48 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823763003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823763003/40001
4 years, 9 months ago (2016-03-22 11:53:57 UTC) #7
Fady Samuel
+piman@ for move review +dcheng@ for messages review PTAL! Thanks! This is a fairly straightforward ...
4 years, 9 months ago (2016-03-22 11:59:33 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/39247)
4 years, 9 months ago (2016-03-22 12:10:12 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823763003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823763003/60001
4 years, 9 months ago (2016-03-22 12:33:09 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 13:32:13 UTC) #18
piman
https://codereview.chromium.org/1823763003/diff/60001/gpu/ipc/common/gpu_process_launch_causes.h File gpu/ipc/common/gpu_process_launch_causes.h (right): https://codereview.chromium.org/1823763003/diff/60001/gpu/ipc/common/gpu_process_launch_causes.h#newcode8 gpu/ipc/common/gpu_process_launch_causes.h:8: namespace gpu { Did this file need to move? ...
4 years, 9 months ago (2016-03-22 15:14:55 UTC) #19
piman
https://codereview.chromium.org/1823763003/diff/60001/gpu/ipc/common/gpu_process_launch_causes.h File gpu/ipc/common/gpu_process_launch_causes.h (right): https://codereview.chromium.org/1823763003/diff/60001/gpu/ipc/common/gpu_process_launch_causes.h#newcode8 gpu/ipc/common/gpu_process_launch_causes.h:8: namespace gpu { Did this file need to move? ...
4 years, 9 months ago (2016-03-22 15:14:55 UTC) #20
Fady Samuel
PTAL Antoine! Thanks! https://codereview.chromium.org/1823763003/diff/60001/gpu/ipc/common/gpu_process_launch_causes.h File gpu/ipc/common/gpu_process_launch_causes.h (right): https://codereview.chromium.org/1823763003/diff/60001/gpu/ipc/common/gpu_process_launch_causes.h#newcode8 gpu/ipc/common/gpu_process_launch_causes.h:8: namespace gpu { On 2016/03/22 15:14:55, ...
4 years, 9 months ago (2016-03-22 21:54:21 UTC) #22
piman
lgtm
4 years, 9 months ago (2016-03-22 22:07:06 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823763003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823763003/80001
4 years, 9 months ago (2016-03-22 22:08:47 UTC) #25
dcheng
lgtm
4 years, 9 months ago (2016-03-22 22:11:23 UTC) #26
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/110632) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years, 9 months ago (2016-03-22 22:21:05 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823763003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823763003/120001
4 years, 9 months ago (2016-03-23 01:17:30 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/110746)
4 years, 9 months ago (2016-03-23 01:29:53 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823763003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823763003/140001
4 years, 9 months ago (2016-03-23 02:04:21 UTC) #37
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 9 months ago (2016-03-23 03:41:13 UTC) #38
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 03:42:31 UTC) #40
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/efd3ce2aac23c08d4b3296a217359af73edc8629
Cr-Commit-Position: refs/heads/master@{#382785}

Powered by Google App Engine
This is Rietveld 408576698