Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1823763002:
Add vector icon dependency to components/toolbar (Closed)
|
Created:
4 years, 9 months ago by Evan Stade Modified:
4 years, 9 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd vector icon dependency to components/toolbar
BUG=596387
TBR=blundell@chromium.org
Committed: https://crrev.com/6238b2033e0c7ffd6b0996ba42b60f39380ecd96
Cr-Commit-Position: refs/heads/master@{#382499}
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
The CQ bit was checked by estade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823763002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
estade@chromium.org changed reviewers: + pkasting@chromium.org
On 2016/03/22 00:13:09, Evan Stade wrote: RS LGTM
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823763002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Add vector icon dependency to components/toolbar BUG=596387 ========== to ========== Add vector icon dependency to components/toolbar BUG=596387 TBR=blundell@chromium.org ==========
estade@chromium.org changed reviewers: + blundell@chromium.org
tbr blundell
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823763002/1
Message was sent while issue was closed.
Description was changed from ========== Add vector icon dependency to components/toolbar BUG=596387 TBR=blundell@chromium.org ========== to ========== Add vector icon dependency to components/toolbar BUG=596387 TBR=blundell@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add vector icon dependency to components/toolbar BUG=596387 TBR=blundell@chromium.org ========== to ========== Add vector icon dependency to components/toolbar BUG=596387 TBR=blundell@chromium.org Committed: https://crrev.com/6238b2033e0c7ffd6b0996ba42b60f39380ecd96 Cr-Commit-Position: refs/heads/master@{#382499} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6238b2033e0c7ffd6b0996ba42b60f39380ecd96 Cr-Commit-Position: refs/heads/master@{#382499}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
