Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1823753002: SkPDF: record milestone version in Producer string (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
hcm, tomhudson, reed1
CC:
reviews_skia.org, bungeman-skia, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 2016-03-28 (Monday) 16:13:43 EDT #

Patch Set 3 : include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -3 lines) Patch
A + include/core/SkMilestone.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/pdf/SkPDFMetadata.cpp View 1 4 chunks +8 lines, -1 line 0 comments Download
M tests/PDFMetadataAttributeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A tools/milestone.py View 1 2 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823753002/1
4 years, 9 months ago (2016-03-21 20:10:00 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-21 20:22:54 UTC) #5
hal.canary
PTAL motivation: make debugging non-Chrome PDFs easier.
4 years, 9 months ago (2016-03-21 20:42:11 UTC) #7
tomhudson
How are we going to maintain?
4 years, 9 months ago (2016-03-22 12:21:23 UTC) #8
hal.canary
On 2016/03/22 12:21:23, tomhudson wrote: > How are we going to maintain? After each branch, ...
4 years, 9 months ago (2016-03-22 12:24:20 UTC) #9
tomhudson
This overlaps heavily with https://codereview.chromium.org/1781673002/. Will Heather commit to making the milestone change part of ...
4 years, 9 months ago (2016-03-22 13:10:47 UTC) #11
hcm
On 2016/03/22 13:10:47, tomhudson wrote: > This overlaps heavily with https://codereview.chromium.org/1781673002/. > > Will Heather ...
4 years, 9 months ago (2016-03-22 14:34:31 UTC) #12
hal.canary
On 2016/03/22 14:34:31, hcm wrote: > On 2016/03/22 13:10:47, tomhudson wrote: > > This overlaps ...
4 years, 9 months ago (2016-03-24 14:26:28 UTC) #13
hal.canary
hcm@, Is this close to what you were looking for?
4 years, 8 months ago (2016-03-28 20:15:15 UTC) #14
tomhudson
Yes, the root is to have a constant that can be used in multiple places ...
4 years, 8 months ago (2016-03-28 20:23:19 UTC) #15
hcm
On 2016/03/28 20:23:19, tomhudson wrote: > Yes, the root is to have a constant that ...
4 years, 8 months ago (2016-03-29 13:42:59 UTC) #16
hal.canary
On 2016/03/29 13:42:59, hcm wrote: > [...] can we move to include/ so that clients ...
4 years, 8 months ago (2016-03-29 14:06:59 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823753002/40001
4 years, 8 months ago (2016-03-29 14:10:13 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 14:20:05 UTC) #21
hcm
On 2016/03/29 14:20:05, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 8 months ago (2016-03-29 14:34:04 UTC) #22
tomhudson
Feels like automation may be overkill, but LGTM.
4 years, 8 months ago (2016-03-29 14:46:03 UTC) #23
hal.canary
adding reed@ for include/
4 years, 8 months ago (2016-03-29 14:48:59 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823753002/40001
4 years, 8 months ago (2016-03-29 16:08:37 UTC) #29
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 16:09:33 UTC) #31
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ffe54004b92f84b65ee4569aaccbc178c51b017f

Powered by Google App Engine
This is Rietveld 408576698