Disable the WIC encoder for jpegs

Disable the WIC encoder for jpegs

My fix from https://codereview.chromium.org/1791583002/ is not
sufficient.

WIC will only encode JPEGs if we pass in a bitmap in BGR
format.  For now, let's disable the WIC encoder on JPEGs
and fall back on SkImageEncoder_libjpeg.

This should fix the scaled-generator gm.
https://gold.skia.org/search2?query=source_type%3Dgm%26name%3Dscale-generator&include=false&head=true&unt=true&pos=false&neg=false&limit=100

BUG=skia:3969
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1823743002

Committed: https://skia.googlesource.com/skia/+/60316a9ec4b3d76ff3b63952f463f8ddee8841f8

[msarett, 2016-03-21 19:32:32]

Description was changed from

==========
Disable the WIC encoder for jpegs

My fix from https://codereview.chromium.org/1791583002/ is not
sufficient.

WIC will only encode JPEGs if we pass in a bitmap in BGR
format.  For now, let's disable the WIC encoder on JPEGs
and fall back on SkImageEncoder_libjpeg.

This should fix the scaled-generator gm.
https://gold.skia.org/search2?query=source_type%3Dgm%26name%3Dscale-generator...

BUG=skia:
==========

to

==========
Disable the WIC encoder for jpegs

My fix from https://codereview.chromium.org/1791583002/ is not
sufficient.

WIC will only encode JPEGs if we pass in a bitmap in BGR
format.  For now, let's disable the WIC encoder on JPEGs
and fall back on SkImageEncoder_libjpeg.

This should fix the scaled-generator gm.
https://gold.skia.org/search2?query=source_type%3Dgm%26name%3Dscale-generator...

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-03-21 20:09:28]

msarett@google.com changed reviewers:
+ bsalomon@google.com, scroggo@google.com

[msarett, 2016-03-21 20:09:28]

The neglects the two real fixes that need to be made:
(1) Actually fix the WIC jpeg encoder.
(2) Control when we use or don't use the platform encoders (rather than being
dependent on the order in which stuff links)

https://codereview.chromium.org/1823743002/diff/1/src/ports/SkImageDecoder_WI...
File src/ports/SkImageDecoder_WIC.cpp (right):

https://codereview.chromium.org/1823743002/diff/1/src/ports/SkImageDecoder_WI...
src/ports/SkImageDecoder_WIC.cpp:414: if (SUCCEEDED(hr)) {
Adding back in code that I deleted in
https://codereview.chromium.org/1791583002/.

[scroggo, 2016-03-21 20:19:17]

lgtm

I just realized there's a bug for this skbug.com/3969 (at least, I think it's
related). Could you add that to the description?

[msarett, 2016-03-21 20:22:33]

Description was changed from

==========
Disable the WIC encoder for jpegs

My fix from https://codereview.chromium.org/1791583002/ is not
sufficient.

WIC will only encode JPEGs if we pass in a bitmap in BGR
format.  For now, let's disable the WIC encoder on JPEGs
and fall back on SkImageEncoder_libjpeg.

This should fix the scaled-generator gm.
https://gold.skia.org/search2?query=source_type%3Dgm%26name%3Dscale-generator...

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Disable the WIC encoder for jpegs

My fix from https://codereview.chromium.org/1791583002/ is not
sufficient.

WIC will only encode JPEGs if we pass in a bitmap in BGR
format.  For now, let's disable the WIC encoder on JPEGs
and fall back on SkImageEncoder_libjpeg.

This should fix the scaled-generator gm.
https://gold.skia.org/search2?query=source_type%3Dgm%26name%3Dscale-generator...

BUG=skia:3969
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-03-21 20:22:44]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-03-21 20:22:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823743002/1

[commit-bot: I haz the power, 2016-03-21 20:35:45]

Description was changed from

==========
Disable the WIC encoder for jpegs

My fix from https://codereview.chromium.org/1791583002/ is not
sufficient.

WIC will only encode JPEGs if we pass in a bitmap in BGR
format.  For now, let's disable the WIC encoder on JPEGs
and fall back on SkImageEncoder_libjpeg.

This should fix the scaled-generator gm.
https://gold.skia.org/search2?query=source_type%3Dgm%26name%3Dscale-generator...

BUG=skia:3969
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Disable the WIC encoder for jpegs

My fix from https://codereview.chromium.org/1791583002/ is not
sufficient.

WIC will only encode JPEGs if we pass in a bitmap in BGR
format.  For now, let's disable the WIC encoder on JPEGs
and fall back on SkImageEncoder_libjpeg.

This should fix the scaled-generator gm.
https://gold.skia.org/search2?query=source_type%3Dgm%26name%3Dscale-generator...

BUG=skia:3969
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/60316a9ec4b3d76ff3b63952f463f8ddee8841f8
==========

[commit-bot: I haz the power, 2016-03-21 20:35:46]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/60316a9ec4b3d76ff3b63952f463f8ddee8841f8