Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: tests/language/logical_expression2_test.dart

Issue 182373002: Fix bad type-inferrence for logical expressions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use lhs of &&. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 import "package:expect/expect.dart";
6
7 // Regression test for issue 17149.
8
9 int globalCounter = 0;
10
11 void nonInlinedUse(Object object) {
12 if (new DateTime.now().millisecondsSinceEpoch == 42) nonInlinedUse(object);
13 if (object is! String) globalCounter++;
14 }
15
16 int confuse(x) {
17 if (new DateTime.now().millisecondsSinceEpoch == 42) return confuse(x - 1);
18 return x;
19 }
20
21 main() {
22 var o = [ "foo", 499 ][confuse(1)];
23
24 // The `o is String` check in the rhs of the logical or must not be
25 // propagated to the `if` body.
26 if ((o is num) ||
27 (o is String && true)) {
28 nonInlinedUse(o);
29 }
30 Expect.equals(1, globalCounter);
31 }
OLDNEW
« no previous file with comments | « tests/compiler/dart2js/simple_inferrer_and_or_test.dart ('k') | tests/language/logical_expression3_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698