Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Unified Diff: media/video/gpu_memory_buffer_video_frame_pool_unittest.cc

Issue 1823683002: media: GpuMemoryBufferVideoFramePool uses BindToCurrentLoop() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix unittests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
diff --git a/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc b/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
index 36f6552c65d2c6fa2bfb7d39193a91d6c414f3e4..1ac8360ce95582e54a4de0d407ee26fd6b5156aa 100644
--- a/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
+++ b/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/test/test_simple_task_runner.h"
+#include "base/thread_task_runner_handle.h"
#include "gpu/command_buffer/client/gles2_interface_stub.h"
#include "media/base/video_frame.h"
#include "media/renderers/mock_gpu_video_accelerator_factories.h"
@@ -72,6 +73,8 @@ class GpuMemoryBufferVideoFramePoolTest : public ::testing::Test {
gles2_.reset(new TestGLES2Interface);
media_task_runner_ = make_scoped_refptr(new base::TestSimpleTaskRunner);
copy_task_runner_ = make_scoped_refptr(new base::TestSimpleTaskRunner);
+ media_task_runner_handle_.reset(
+ new base::ThreadTaskRunnerHandle(media_task_runner_));
dshwang 2016/03/21 18:31:23 To use BindToCurrentLoop, unittest has to define T
Daniele Castagna 2016/03/21 18:45:19 You might want to add this comment here.
dshwang 2016/03/21 19:04:38 Done.
mock_gpu_factories_.reset(
new MockGpuVideoAcceleratorFactories(gles2_.get()));
gpu_memory_buffer_pool_.reset(new GpuMemoryBufferVideoFramePool(
@@ -123,6 +126,7 @@ class GpuMemoryBufferVideoFramePoolTest : public ::testing::Test {
scoped_ptr<GpuMemoryBufferVideoFramePool> gpu_memory_buffer_pool_;
scoped_refptr<base::TestSimpleTaskRunner> media_task_runner_;
scoped_refptr<base::TestSimpleTaskRunner> copy_task_runner_;
+ scoped_ptr<base::ThreadTaskRunnerHandle> media_task_runner_handle_;
scoped_ptr<TestGLES2Interface> gles2_;
};

Powered by Google App Engine
This is Rietveld 408576698