Swarming: Ensure depot_tools is in PATH when compiling

Swarming: Ensure depot_tools is in PATH when compiling

Turns out we were "lucky" for our Linux bots which already have depot_tools in PATH. The Mac bot does have depot_tools, but it's not in PATH.  Add it in the script to ensure we can always get to it.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1823653002

Committed: https://skia.googlesource.com/skia/+/423ba24cac329550fb20135707dbfc71686e7596

[borenet2, 2016-03-21 15:33:50]

Description was changed from

==========
Swarming: Ensure depot_tools is in PATH when compiling

BUG=skia:4763
==========

to

==========
Swarming: Ensure depot_tools is in PATH when compiling

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[borenet, 2016-03-21 15:48:46]

Description was changed from

==========
Swarming: Ensure depot_tools is in PATH when compiling

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Swarming: Ensure depot_tools is in PATH when compiling

Turns out we were "lucky" for our Linux bots which already have depot_tools in
PATH. The Mac bot does have depot_tools, but it's not in PATH.  Add it in the
script to ensure we can always get to it.

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[borenet, 2016-03-21 15:48:54]

borenet@google.com changed reviewers:
+ borenet@google.com, rmistry@google.com

[borenet, 2016-03-21 15:49:44]

Description was changed from

==========
Swarming: Ensure depot_tools is in PATH when compiling

Turns out we were "lucky" for our Linux bots which already have depot_tools in
PATH. The Mac bot does have depot_tools, but it's not in PATH.  Add it in the
script to ensure we can always get to it.

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Swarming: Ensure depot_tools is in PATH when compiling

Turns out we were "lucky" for our Linux bots which already have depot_tools in
PATH. The Mac bot does have depot_tools, but it's not in PATH.  Add it in the
script to ensure we can always get to it.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[rmistry, 2016-03-21 15:57:31]

lgtm

Does not look like our linux GCE instances have /b/depot_tools

[borenet, 2016-03-21 16:00:31]

On 2016/03/21 15:57:31, rmistry wrote:
> lgtm
> 
> Does not look like our linux GCE instances have /b/depot_tools

For consistency with chrome-infra, I propose that for Swarming bots we do our
work in /b instead of /home/default/storage/skia-repo.  But we can hammer out
those details later.  For the moment it's easy enough to support both.

[borenet, 2016-03-21 16:01:41]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2016-03-21 16:01:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823653002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823653002/1

[rmistry, 2016-03-21 16:02:15]

On 2016/03/21 16:00:31, borenet wrote:
> On 2016/03/21 15:57:31, rmistry wrote:
> > lgtm
> > 
> > Does not look like our linux GCE instances have /b/depot_tools
> 
> For consistency with chrome-infra, I propose that for Swarming bots we do our
> work in /b instead of /home/default/storage/skia-repo.  But we can hammer out
> those details later.  For the moment it's easy enough to support both.

Yes swarming bots should do all work in /b. This is why the swarming images have
the persistent disk mounted on /b.
It should be straightforward to modify the GCE automation scripts to checkout
depot_tools in /b/ for only swarming bots.

[commit-bot: I haz the power, 2016-03-21 16:02:53]

Description was changed from

==========
Swarming: Ensure depot_tools is in PATH when compiling

Turns out we were "lucky" for our Linux bots which already have depot_tools in
PATH. The Mac bot does have depot_tools, but it's not in PATH.  Add it in the
script to ensure we can always get to it.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Swarming: Ensure depot_tools is in PATH when compiling

Turns out we were "lucky" for our Linux bots which already have depot_tools in
PATH. The Mac bot does have depot_tools, but it's not in PATH.  Add it in the
script to ensure we can always get to it.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/423ba24cac329550fb20135707dbfc71686e7596
==========

[commit-bot: I haz the power, 2016-03-21 16:02:54]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/423ba24cac329550fb20135707dbfc71686e7596