Don't suspend before there is metadata.

Don't suspend before there is metadata.

This functionality was inadvertantly removed. Also in this CL, we
resume in OnShown() is we do not yet have matadata, which could
happen if we were forcefully suspended (tab closed) at that stage.

BUG=596239
Committed: https://crrev.com/520b46bd833ba35ece1ce1baf29f7932821dd603
Cr-Commit-Position: refs/heads/master@{#382391}

[sandersd (OOO until July 31), 2016-03-21 19:52:34]

sandersd@chromium.org changed reviewers:
+ dalecurtis@google.com

[DaleCurtis, 2016-03-21 19:54:33]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-03-21 19:54:34]

https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:1068: // Don't suspend before matadata is
available.
What happens during a seek? Do we transition to have nothing? If so the seek()
may never hit the have metadata above. Perhaps we want to move the above check
below as well? If >= metadata and should_Suspend?

[sandersd (OOO until July 31), 2016-03-21 19:59:44]

https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:1068: // Don't suspend before matadata is
available.
On 2016/03/21 19:54:34, DaleCurtis wrote:
> What happens during a seek? Do we transition to have nothing? If so the seek()
> may never hit the have metadata above. Perhaps we want to move the above check
> below as well? If >= metadata and should_Suspend?

During seek, we set the state to ReadyStateHaveMetadata, so the check will pass.
Note that OnPipelineBufferingStateChanged() also drops changes during seek or
while suspended.

[DaleCurtis, 2016-03-21 20:04:50]

https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:1098: if (ready_state_ <
WebMediaPlayer::ReadyStateHaveMetadata ||
We want to resume when it's less than have metadata?

[sandersd (OOO until July 31), 2016-03-21 20:12:26]

https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:1098: if (ready_state_ <
WebMediaPlayer::ReadyStateHaveMetadata ||
On 2016/03/21 20:04:50, DaleCurtis wrote:
> We want to resume when it's less than have metadata?

Yes. I added a comment to explain.

[DaleCurtis, 2016-03-21 20:14:23]

Thanks! lgtm

[sandersd (OOO until July 31), 2016-03-21 20:14:54]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2016-03-21 20:15:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823643003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823643003/40001

[commit-bot: I haz the power, 2016-03-21 21:18:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-21 21:20:49]

Description was changed from

==========
Don't suspend before there is metadata.

This functionality was inadvertantly removed. Also in this CL, we
resume in OnShown() is we do not yet have matadata, which could
happen if we were forcefully suspended (tab closed) at that stage.

BUG=596239
==========

to

==========
Don't suspend before there is metadata.

This functionality was inadvertantly removed. Also in this CL, we
resume in OnShown() is we do not yet have matadata, which could
happen if we were forcefully suspended (tab closed) at that stage.

BUG=596239

Committed: https://crrev.com/520b46bd833ba35ece1ce1baf29f7932821dd603
Cr-Commit-Position: refs/heads/master@{#382391}
==========

[commit-bot: I haz the power, 2016-03-21 21:20:50]

Patchset 3 (id:??) landed as
https://crrev.com/520b46bd833ba35ece1ce1baf29f7932821dd603
Cr-Commit-Position: refs/heads/master@{#382391}