Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1823643003: Don't suspend before there is metadata. (Closed)

Created:
4 years, 9 months ago by sandersd (OOO until July 31)
Modified:
4 years, 9 months ago
Reviewers:
Dale Curtis, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't suspend before there is metadata. This functionality was inadvertantly removed. Also in this CL, we resume in OnShown() is we do not yet have matadata, which could happen if we were forcefully suspended (tab closed) at that stage. BUG=596239 Committed: https://crrev.com/520b46bd833ba35ece1ce1baf29f7932821dd603 Cr-Commit-Position: refs/heads/master@{#382391}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 2 3 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
sandersd (OOO until July 31)
4 years, 9 months ago (2016-03-21 19:52:35 UTC) #2
DaleCurtis
https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_impl.cc#newcode1068 media/blink/webmediaplayer_impl.cc:1068: // Don't suspend before matadata is available. What happens ...
4 years, 9 months ago (2016-03-21 19:54:34 UTC) #4
sandersd (OOO until July 31)
https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_impl.cc#newcode1068 media/blink/webmediaplayer_impl.cc:1068: // Don't suspend before matadata is available. On 2016/03/21 ...
4 years, 9 months ago (2016-03-21 19:59:44 UTC) #5
DaleCurtis
https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_impl.cc#newcode1098 media/blink/webmediaplayer_impl.cc:1098: if (ready_state_ < WebMediaPlayer::ReadyStateHaveMetadata || We want to resume ...
4 years, 9 months ago (2016-03-21 20:04:50 UTC) #6
sandersd (OOO until July 31)
https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/1823643003/diff/1/media/blink/webmediaplayer_impl.cc#newcode1098 media/blink/webmediaplayer_impl.cc:1098: if (ready_state_ < WebMediaPlayer::ReadyStateHaveMetadata || On 2016/03/21 20:04:50, DaleCurtis ...
4 years, 9 months ago (2016-03-21 20:12:26 UTC) #7
DaleCurtis
Thanks! lgtm
4 years, 9 months ago (2016-03-21 20:14:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823643003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823643003/40001
4 years, 9 months ago (2016-03-21 20:15:32 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-21 21:18:53 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 21:20:50 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/520b46bd833ba35ece1ce1baf29f7932821dd603
Cr-Commit-Position: refs/heads/master@{#382391}

Powered by Google App Engine
This is Rietveld 408576698