Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issue 1823623002: [crankshaft] Delete unused Hydrogen-BCH code (Closed)

Created:
4 years, 9 months ago by Jakob Kummerow
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Delete unused Hydrogen-BCH code Bounds check hoisting was known to be buggy and has never been turned on. Since Crankshaft is deprecated, nobody is going to spend time fixing it, so let's just get rid of it. BUG=v8:4155, v8:4849 LOG=n R=bmeurer@chromium.org Committed: https://crrev.com/6703cce1b76fe3d2ab1a639c1115e8c08f9832d6 Cr-Commit-Position: refs/heads/master@{#34948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1333 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D src/crankshaft/hydrogen-bch.h View 1 chunk +0 lines, -33 lines 0 comments Download
D src/crankshaft/hydrogen-bch.cc View 1 chunk +0 lines, -379 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 13 chunks +0 lines, -341 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 4 chunks +0 lines, -508 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
PTAL.
4 years, 9 months ago (2016-03-21 13:07:58 UTC) #1
Benedikt Meurer
Awesome! LGTM.
4 years, 9 months ago (2016-03-21 13:59:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823623002/1
4 years, 9 months ago (2016-03-21 14:01:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 15:06:06 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 15:07:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6703cce1b76fe3d2ab1a639c1115e8c08f9832d6
Cr-Commit-Position: refs/heads/master@{#34948}

Powered by Google App Engine
This is Rietveld 408576698