Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1823613002: Simplify JSArray::HasReadOnlyLength (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify JSArray::HasReadOnlyLength BUG= Committed: https://crrev.com/f7bac43d4ac485e9609e77a34816a36e2fa0d728 Cr-Commit-Position: refs/heads/master@{#34956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/objects.cc View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-21 12:30:49 UTC) #2
Camillo Bruni
lgtm
4 years, 9 months ago (2016-03-21 12:31:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823613002/1
4 years, 9 months ago (2016-03-21 12:33:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/15566)
4 years, 9 months ago (2016-03-21 15:02:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823613002/1
4 years, 9 months ago (2016-03-21 15:05:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 17:12:13 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 17:13:38 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f7bac43d4ac485e9609e77a34816a36e2fa0d728
Cr-Commit-Position: refs/heads/master@{#34956}

Powered by Google App Engine
This is Rietveld 408576698