Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3987)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java

Issue 1823593002: Pass the time parameter to PrefServiceBridge.clearBrowsingData() explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
index b3d9594e97bdb3ac15c0b18a3e489c48ceeb7dc9..bdcd518805ca11e8d26ef41e04b29f17a9d75d24 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
@@ -684,11 +684,14 @@ public final class PrefServiceBridge {
* @param listener A listener to call back when the clearing is finished.
* @param dataTypes An array of browsing data types to delete, represented as values from
* the shared enum {@link org.chromium.chrome.browser.BrowsingDataType}.
+ * @param timePeriod The time period for which to delete the data, represented as a value from
+ * the shared enum {@link org.chromium.chrome.browser.TimePeriod}.
*/
- public void clearBrowsingData(OnClearBrowsingDataListener listener, int[] dataTypes) {
+ public void clearBrowsingData(
+ OnClearBrowsingDataListener listener, int[] dataTypes, int timePeriod) {
assert mClearBrowsingDataListener == null;
mClearBrowsingDataListener = listener;
- nativeClearBrowsingData(dataTypes);
+ nativeClearBrowsingData(dataTypes, timePeriod);
}
/*
@@ -995,7 +998,7 @@ public final class PrefServiceBridge {
private native void nativeSetBrowsingDataDeletionPreference(int dataType, boolean value);
private native int nativeGetBrowsingDataDeletionTimePeriod();
private native void nativeSetBrowsingDataDeletionTimePeriod(int timePeriod);
- private native void nativeClearBrowsingData(int[] dataTypes);
+ private native void nativeClearBrowsingData(int[] dataTypes, int timePeriod);
private native boolean nativeCanDeleteBrowsingHistory();
private native void nativeSetAllowCookiesEnabled(boolean allow);
private native void nativeSetBlockThirdPartyCookiesEnabled(boolean enabled);

Powered by Google App Engine
This is Rietveld 408576698