src/core/SkCanvas.cpp - Issue 1823573003: Change signatures of filter bounds methods to return a rect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkCanvas.cpp

Issue 1823573003: Change signatures of filter bounds methods to return a rect. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Hide legacy API behind #ifdef; switch callers to new API Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkCanvas.cpp

diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp

index 3acb9136e25814bacb4a725d402820986f56fdf6..3efb44cc548bed305cf0c18450e9b45f91b6711d 100644

--- a/src/core/SkCanvas.cpp

+++ b/src/core/SkCanvas.cpp

@@ -1077,7 +1077,7 @@ bool SkCanvas::clipRectBounds(const SkRect* bounds, SaveLayerFlags saveLayerFlag

const SkMatrix& ctm = fMCRec->fMatrix; // this->getTotalMatrix()

if (imageFilter) {

- imageFilter->filterBounds(clipBounds, ctm, &clipBounds);

+ clipBounds = imageFilter->filterBounds(clipBounds, ctm);

if (bounds && !imageFilter->canComputeFastBounds()) {

bounds = nullptr;

}