Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1823523002: [stubs] Unify the type conversion call interface descriptors. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Unify the type conversion call interface descriptors. Up until now all type conversions (i.e. ToNumber, ToString and friends) had their own specific call interface descriptors, where some of them had to match (i.e. ToString and NumberToString have to use the same argument register). Instead of all the different descriptors, it's sufficient to have a single TypeConversionDescriptor instead. R=jarin@chromium.org Committed: https://crrev.com/524d01945c8ab718929becb504bcd424eda31f16 Cr-Commit-Position: refs/heads/master@{#34916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -408 lines) Patch
M src/arm/interface-descriptors-arm.cc View 2 chunks +1 line, -35 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 2 chunks +1 line, -38 lines 0 comments Download
M src/code-stubs.h View 8 chunks +8 lines, -8 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 2 chunks +1 line, -36 lines 0 comments Download
M src/interface-descriptors.h View 4 chunks +5 lines, -60 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +2 lines, -24 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 2 chunks +1 line, -35 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 2 chunks +1 line, -35 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 2 chunks +1 line, -34 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 2 chunks +1 line, -28 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 2 chunks +1 line, -36 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 2 chunks +1 line, -35 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-21 05:18:14 UTC) #1
Benedikt Meurer
Hey Jaro, Some unification of the interface descriptors. Please take a look. Thanks, Benedikt
4 years, 9 months ago (2016-03-21 05:21:25 UTC) #2
Jarin
lgtm
4 years, 9 months ago (2016-03-21 05:27:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823523002/1
4 years, 9 months ago (2016-03-21 05:27:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 06:02:26 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 06:03:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/524d01945c8ab718929becb504bcd424eda31f16
Cr-Commit-Position: refs/heads/master@{#34916}

Powered by Google App Engine
This is Rietveld 408576698