Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: masters/master.chromium.memory.fyi/master.cfg

Issue 1823453002: Revert of Temporarily switch the compiler back to VS2013 on DrMemory bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: masters/master.chromium.memory.fyi/master.cfg
diff --git a/masters/master.chromium.memory.fyi/master.cfg b/masters/master.chromium.memory.fyi/master.cfg
index d50dc904b41960ef5e8c28626b2c6d2f92fe5e38..f141ea1ef80764bd0d395a44af5a0d04bef43fc0 100644
--- a/masters/master.chromium.memory.fyi/master.cfg
+++ b/masters/master.chromium.memory.fyi/master.cfg
@@ -328,13 +328,10 @@
# TODO(timurrrr): Might wanna remove chromium_builder_dbg_drmemory_win
# entirely as ninja supports target lists similar to what we always had
# on Linux.
- # TODO(zhaoqin|bruening): Temporarily using VS2013 due to bugs in DrMemory.
- # crbug.com/594808.
options=['--build-tool=ninja', '--', 'chromium_builder_dbg_drmemory_win'],
factory_properties={
'gclient_env': {'GYP_DEFINES': ('build_for_tool=drmemory '
'component=shared_library '),
- 'GYP_MSVS_VERSION': '2013',
'GYP_GENERATORS': 'ninja'},
'package_pdb_files': True,
'trigger': 'chromium_win_drmemory',
@@ -528,15 +525,12 @@
target='Release_x64',
# TODO(bruening): remove "_dbg" from this name in all.gyp as it is
# not limited to just Debug.
- # TODO(zhaoqin|bruening): Temporarily using VS2013 due to bugs in DrMemory.
- # crbug.com/594808.
options=['--build-tool=ninja', '--', 'chromium_builder_dbg_drmemory_win'],
factory_properties={
'gclient_env': {
'GYP_DEFINES' : (
'build_for_tool=drmemory component=shared_library '
'target_arch=x64'),
- 'GYP_MSVS_VERSION': '2013',
'GYP_GENERATORS': 'ninja',
},
'package_pdb_files': True,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698