Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1823423005: [libfuzzer] UBSan build configuration (Closed)

Created:
4 years, 9 months ago by aizatsky
Modified:
4 years, 9 months ago
Reviewers:
mmoroz, Dirk Pranke, inferno
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[libfuzzer] UBSan build configuration BUG=596650 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299497

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M scripts/slave/recipes/chromium_libfuzzer.py View 1 chunk +11 lines, -0 lines 3 comments Download
A + scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_UBSan.json View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
aizatsky
Corresponding mb config is in: https://codereview.chromium.org/1832213002/
4 years, 9 months ago (2016-03-25 20:54:18 UTC) #3
inferno
lgtm
4 years, 9 months ago (2016-03-25 20:58:44 UTC) #4
Dirk Pranke
lgtm except w/ question ... https://codereview.chromium.org/1823423005/diff/1/scripts/slave/recipes/chromium_libfuzzer.py File scripts/slave/recipes/chromium_libfuzzer.py (right): https://codereview.chromium.org/1823423005/diff/1/scripts/slave/recipes/chromium_libfuzzer.py#newcode51 scripts/slave/recipes/chromium_libfuzzer.py:51: 'chromium_apply_config': [ 'proprietary_codecs' ], ...
4 years, 9 months ago (2016-03-25 21:15:20 UTC) #5
aizatsky
https://codereview.chromium.org/1823423005/diff/1/scripts/slave/recipes/chromium_libfuzzer.py File scripts/slave/recipes/chromium_libfuzzer.py (right): https://codereview.chromium.org/1823423005/diff/1/scripts/slave/recipes/chromium_libfuzzer.py#newcode51 scripts/slave/recipes/chromium_libfuzzer.py:51: 'chromium_apply_config': [ 'proprietary_codecs' ], On 2016/03/25 21:15:20, Dirk Pranke ...
4 years, 9 months ago (2016-03-25 21:16:33 UTC) #6
Dirk Pranke
https://codereview.chromium.org/1823423005/diff/1/scripts/slave/recipes/chromium_libfuzzer.py File scripts/slave/recipes/chromium_libfuzzer.py (right): https://codereview.chromium.org/1823423005/diff/1/scripts/slave/recipes/chromium_libfuzzer.py#newcode51 scripts/slave/recipes/chromium_libfuzzer.py:51: 'chromium_apply_config': [ 'proprietary_codecs' ], On 2016/03/25 21:16:33, aizatsky wrote: ...
4 years, 9 months ago (2016-03-25 21:20:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823423005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823423005/1
4 years, 9 months ago (2016-03-25 22:15:47 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 22:19:28 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299497

Powered by Google App Engine
This is Rietveld 408576698