[Password Manager] Changes implementation of left elided origins (Relanding)

[Password Manager] Changes implementation of left elided origins on chrome://settings/passwords (Relanding)

Reland https://codereview.chromium.org/1826533003/. It broke Closure Linux Compilation bot (https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/50842). The bot complained on parseInt calls. parseInt should be called with 2 arguments (parsed string and base).

There was also a bug in the algorithm of updateOriginsEliding_. Reproduction: user enters a query w/o any matching entries in search box (i.e. there will be no entries) and then removes the query. The algorithm falls into infinite loop, because entry.urlDiv.offsetWidth is 0. We have to swap updateOriginsEliding_ and updateListVisibility_ to update the list before we read entry.urlDiv.offsetWidth.

BUG=595662, 595276
Committed: https://crrev.com/fa2ae1d61d3bb8d61e6bf2aee4d17662925d70ab
Cr-Commit-Position: refs/heads/master@{#383927}

[kolos1, 2016-03-23 10:02:23]

Description was changed from

==========
[Password Manager] Changes implementation of left elided origin on
chrome://settings/passwords (Relanding)

Reland https://codereview.chromium.org/1826533003/. It broke Closure Linux
Compilation bot
(https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Li...).
The bot complained on parseInt calls. parseInt should be called with 2 arguments
(parsed string and base).

There was also a bug in the algorithm of updateOriginsEliding_. Reproduction:
user enters a query w/o any matching entries in search box (i.e. there will be
no entries) and then removes the query. The algorithm falls into infinite loop,
because entry.urlDiv.offsetWidth is 0. We have to swap updateOriginsEliding_ and
updateListVisibility_ to update the list before we read
entry.urlDiv.offsetWidth.

BUG=595662, 595276
==========

to

==========
[Password Manager] Changes implementation of left elided origins on
chrome://settings/passwords (Relanding)

Reland https://codereview.chromium.org/1826533003/. It broke Closure Linux
Compilation bot
(https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Li...).
The bot complained on parseInt calls. parseInt should be called with 2 arguments
(parsed string and base).

There was also a bug in the algorithm of updateOriginsEliding_. Reproduction:
user enters a query w/o any matching entries in search box (i.e. there will be
no entries) and then removes the query. The algorithm falls into infinite loop,
because entry.urlDiv.offsetWidth is 0. We have to swap updateOriginsEliding_ and
updateListVisibility_ to update the list before we read
entry.urlDiv.offsetWidth.

BUG=595662, 595276
==========

[kolos1, 2016-03-23 10:08:15]

kolos@chromium.org changed reviewers:
+ estade@chromium.org

[kolos1, 2016-03-23 10:08:15]

Hi Evan,

I had to make some fixes (see description). Please review changes.

Regards,
Maxim

[Evan Stade, 2016-03-23 18:53:30]

https://codereview.chromium.org/1823423002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/options/password_manager.js (right):

https://codereview.chromium.org/1823423002/diff/40001/chrome/browser/resource...
chrome/browser/resources/options/password_manager.js:228:
this.updateListVisibility_(this.passwordExceptionsList_);
if the order matters here, that's subtle and deserves a comment.

[kolos1, 2016-03-24 07:45:43]

https://codereview.chromium.org/1823423002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/options/password_manager.js (right):

https://codereview.chromium.org/1823423002/diff/40001/chrome/browser/resource...
chrome/browser/resources/options/password_manager.js:228:
this.updateListVisibility_(this.passwordExceptionsList_);
On 2016/03/23 18:53:30, Evan Stade wrote:
> if the order matters here, that's subtle and deserves a comment.

Done.

[Evan Stade, 2016-03-24 16:29:00]

lgtm

https://codereview.chromium.org/1823423002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/options/password_manager.js (right):

https://codereview.chromium.org/1823423002/diff/60001/chrome/browser/resource...
chrome/browser/resources/options/password_manager.js:178: var columnWidth =
entry.urlDiv.offsetWidth -
to be doubly safe, maybe make sure this doesn't do anything (except log an error
to console?) when this is <= 0

[kolos1, 2016-03-29 08:35:53]

https://codereview.chromium.org/1823423002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/options/password_manager.js (right):

https://codereview.chromium.org/1823423002/diff/60001/chrome/browser/resource...
chrome/browser/resources/options/password_manager.js:178: var columnWidth =
entry.urlDiv.offsetWidth -
On 2016/03/24 16:29:00, Evan Stade wrote:
> to be doubly safe, maybe make sure this doesn't do anything (except log an
error
> to console?) when this is <= 0

Done.

[kolos1, 2016-03-30 06:24:52]

The CQ bit was checked by kolos@chromium.org

[kolos1, 2016-03-30 06:24:53]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1823423002/#ps80001
(title: "Add the check that columnWidth > 0")

[commit-bot: I haz the power, 2016-03-30 06:25:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823423002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823423002/80001

[commit-bot: I haz the power, 2016-03-30 07:52:47]

Description was changed from

==========
[Password Manager] Changes implementation of left elided origins on
chrome://settings/passwords (Relanding)

Reland https://codereview.chromium.org/1826533003/. It broke Closure Linux
Compilation bot
(https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Li...).
The bot complained on parseInt calls. parseInt should be called with 2 arguments
(parsed string and base).

There was also a bug in the algorithm of updateOriginsEliding_. Reproduction:
user enters a query w/o any matching entries in search box (i.e. there will be
no entries) and then removes the query. The algorithm falls into infinite loop,
because entry.urlDiv.offsetWidth is 0. We have to swap updateOriginsEliding_ and
updateListVisibility_ to update the list before we read
entry.urlDiv.offsetWidth.

BUG=595662, 595276
==========

to

==========
[Password Manager] Changes implementation of left elided origins on
chrome://settings/passwords (Relanding)

Reland https://codereview.chromium.org/1826533003/. It broke Closure Linux
Compilation bot
(https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Li...).
The bot complained on parseInt calls. parseInt should be called with 2 arguments
(parsed string and base).

There was also a bug in the algorithm of updateOriginsEliding_. Reproduction:
user enters a query w/o any matching entries in search box (i.e. there will be
no entries) and then removes the query. The algorithm falls into infinite loop,
because entry.urlDiv.offsetWidth is 0. We have to swap updateOriginsEliding_ and
updateListVisibility_ to update the list before we read
entry.urlDiv.offsetWidth.

BUG=595662, 595276
==========

[commit-bot: I haz the power, 2016-03-30 07:52:49]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-30 07:53:56]

Description was changed from

==========
[Password Manager] Changes implementation of left elided origins on
chrome://settings/passwords (Relanding)

Reland https://codereview.chromium.org/1826533003/. It broke Closure Linux
Compilation bot
(https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Li...).
The bot complained on parseInt calls. parseInt should be called with 2 arguments
(parsed string and base).

There was also a bug in the algorithm of updateOriginsEliding_. Reproduction:
user enters a query w/o any matching entries in search box (i.e. there will be
no entries) and then removes the query. The algorithm falls into infinite loop,
because entry.urlDiv.offsetWidth is 0. We have to swap updateOriginsEliding_ and
updateListVisibility_ to update the list before we read
entry.urlDiv.offsetWidth.

BUG=595662, 595276
==========

to

==========
[Password Manager] Changes implementation of left elided origins on
chrome://settings/passwords (Relanding)

Reland https://codereview.chromium.org/1826533003/. It broke Closure Linux
Compilation bot
(https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Li...).
The bot complained on parseInt calls. parseInt should be called with 2 arguments
(parsed string and base).

There was also a bug in the algorithm of updateOriginsEliding_. Reproduction:
user enters a query w/o any matching entries in search box (i.e. there will be
no entries) and then removes the query. The algorithm falls into infinite loop,
because entry.urlDiv.offsetWidth is 0. We have to swap updateOriginsEliding_ and
updateListVisibility_ to update the list before we read
entry.urlDiv.offsetWidth.

BUG=595662, 595276

Committed: https://crrev.com/fa2ae1d61d3bb8d61e6bf2aee4d17662925d70ab
Cr-Commit-Position: refs/heads/master@{#383927}
==========

[commit-bot: I haz the power, 2016-03-30 07:53:57]

Patchset 5 (id:??) landed as
https://crrev.com/fa2ae1d61d3bb8d61e6bf2aee4d17662925d70ab
Cr-Commit-Position: refs/heads/master@{#383927}