Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1823403002: X87: [turbofan] Fix operands for VisitDiv on Intel. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Fix operands for VisitDiv on Intel. port 1da4b88e8200172eab71bc71253a8adf0e08b466 (r34978) original commit message: The idiv instruction has 2 registers as output. This needs to be modeled so that the move optimizer won't incorrectly elide away moves. BUG= Committed: https://crrev.com/7f82fcdc653bde4358e40408df9b0a72b8fc9630 Cr-Commit-Position: refs/heads/master@{#35018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-23 08:27:19 UTC) #2
Mircea Trofin
lgtm
4 years, 9 months ago (2016-03-23 08:29:54 UTC) #3
Weiliang
lgtm
4 years, 9 months ago (2016-03-23 08:31:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823403002/1
4 years, 9 months ago (2016-03-23 08:32:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 08:51:44 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 08:52:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f82fcdc653bde4358e40408df9b0a72b8fc9630
Cr-Commit-Position: refs/heads/master@{#35018}

Powered by Google App Engine
This is Rietveld 408576698