Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 18234004: Add new schemes to content utils (Closed)

Created:
7 years, 5 months ago by gyuyoung-inactive
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, Hajime Morrita
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add new schemes to content utils According to latest content handler spec, new schemes are added to it. Those are geo, magnet, sip, ssh and xmpp. Spec: http://www.w3.org/html/wg/drafts/html/master/webappapis.html#custom-handlers WebKit merge from http://trac.webkit.org/changeset/152162. TESTS=fast/dom/register-protocol-handler.html fast/dom/unregister-protocol-handler.html BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153303

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a trailing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M LayoutTests/fast/dom/register-protocol-handler.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/register-protocol-handler-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/unregister-protocol-handler.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/unregister-protocol-handler-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gyuyoung-inactive
CC'ing Morrita.
7 years, 5 months ago (2013-06-29 00:11:05 UTC) #1
gyuyoung-inactive
Abarth, could you take a look this patch ?
7 years, 5 months ago (2013-06-29 03:45:21 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/18234004/diff/1/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp File Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp (right): https://codereview.chromium.org/18234004/diff/1/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp#newcode62 Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp:62: "xmpp" please add trailing ,
7 years, 5 months ago (2013-06-29 05:55:03 UTC) #3
gyuyoung-inactive
On 2013/06/29 05:55:03, abarth wrote: > lgtm > https://codereview.chromium.org/18234004/diff/1/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp#newcode62 > Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp:62: "xmpp" > please add ...
7 years, 5 months ago (2013-06-29 06:30:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/18234004/6001
7 years, 5 months ago (2013-06-29 18:01:49 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-06-29 19:55:33 UTC) #6
Message was sent while issue was closed.
Change committed as 153303

Powered by Google App Engine
This is Rietveld 408576698