Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: blimp/net/blimp_message_output_buffer.cc

Issue 1823383002: blimp: Increase max payload size limit from 1MB to 5MB. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change limit, remove DCHECK for max output buffer limit. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/net/common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/blimp_message_output_buffer.cc
diff --git a/blimp/net/blimp_message_output_buffer.cc b/blimp/net/blimp_message_output_buffer.cc
index cf194aa3d3c4f7809ec90537d9e4743e3a656675..67d82109c8f6d247b95233de5ba2e66b969e982c 100644
--- a/blimp/net/blimp_message_output_buffer.cc
+++ b/blimp/net/blimp_message_output_buffer.cc
@@ -65,7 +65,10 @@ void BlimpMessageOutputBuffer::ProcessMessage(
message->set_message_id(++prev_message_id_);
current_buffer_size_bytes_ += message->ByteSize();
- DCHECK_GE(max_buffer_size_bytes_, current_buffer_size_bytes_);
+ if (max_buffer_size_bytes_ < current_buffer_size_bytes_)
+ DLOG(WARNING) << "Buffer size Limit Exceeded. Maximum Bytes Limit: "
Kevin M 2016/03/23 18:37:34 Nit: this isn't really a limit anymore, it's more
Khushal 2016/03/23 19:06:49 Done.
+ << max_buffer_size_bytes_
+ << "Buffered Bytes Size: " << current_buffer_size_bytes_;
write_buffer_.push_back(
make_scoped_ptr(new BufferEntry(std::move(message), callback)));
« no previous file with comments | « no previous file | blimp/net/common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698