Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1823383002: blimp: Increase max payload size limit from 1MB to 5MB. (Closed)

Created:
4 years, 9 months ago by Khushal
Modified:
4 years, 9 months ago
Reviewers:
Kevin M
CC:
chromium-reviews, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blimp: Increase max payload size limit. BUG=597026 Committed: https://crrev.com/fe446e5fe8e9b4989f6341b8fe7ec7614fb18a16 Cr-Commit-Position: refs/heads/master@{#382906}

Patch Set 1 #

Patch Set 2 : Change limit, remove DCHECK for max output buffer limit. #

Total comments: 2

Patch Set 3 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M blimp/net/blimp_message_output_buffer.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M blimp/net/common.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Khushal
4 years, 9 months ago (2016-03-23 04:35:33 UTC) #2
Kevin M
lgtm
4 years, 9 months ago (2016-03-23 17:01:08 UTC) #3
Kevin M
Can you add "from 1MB to 3MB" to the end of the CL subject line?
4 years, 9 months ago (2016-03-23 17:01:52 UTC) #4
Khushal
On 2016/03/23 17:01:52, Kevin M wrote: > Can you add "from 1MB to 3MB" to ...
4 years, 9 months ago (2016-03-23 17:57:54 UTC) #6
Kevin M
lgtm https://codereview.chromium.org/1823383002/diff/20001/blimp/net/blimp_message_output_buffer.cc File blimp/net/blimp_message_output_buffer.cc (right): https://codereview.chromium.org/1823383002/diff/20001/blimp/net/blimp_message_output_buffer.cc#newcode69 blimp/net/blimp_message_output_buffer.cc:69: DLOG(WARNING) << "Buffer size Limit Exceeded. Maximum Bytes ...
4 years, 9 months ago (2016-03-23 18:37:35 UTC) #7
Khushal
https://codereview.chromium.org/1823383002/diff/20001/blimp/net/blimp_message_output_buffer.cc File blimp/net/blimp_message_output_buffer.cc (right): https://codereview.chromium.org/1823383002/diff/20001/blimp/net/blimp_message_output_buffer.cc#newcode69 blimp/net/blimp_message_output_buffer.cc:69: DLOG(WARNING) << "Buffer size Limit Exceeded. Maximum Bytes Limit: ...
4 years, 9 months ago (2016-03-23 19:06:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823383002/40001
4 years, 9 months ago (2016-03-23 19:07:20 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-23 19:55:28 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 19:58:42 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe446e5fe8e9b4989f6341b8fe7ec7614fb18a16
Cr-Commit-Position: refs/heads/master@{#382906}

Powered by Google App Engine
This is Rietveld 408576698