Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1823353003: Disable subsequence caching when didLayoutWithPendingStylesheets is true. (Closed)

Created:
4 years, 9 months ago by chrishtr
Modified:
4 years, 9 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable subsequence caching when didLayoutWithPendingStylesheets is true. BUG=593758 Committed: https://crrev.com/27c25394291c192a6a10a83f2bae1c1539feb993 Cr-Commit-Position: refs/heads/master@{#382791}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 3 chunks +9 lines, -3 lines 2 comments Download
M third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
chrishtr
4 years, 9 months ago (2016-03-23 03:10:40 UTC) #3
Xianzhu
lgtm https://codereview.chromium.org/1823353003/diff/20001/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right): https://codereview.chromium.org/1823353003/diff/20001/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp#newcode43 third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:43: // will do a full paintInvalidationForWholeLayoutObject(). The comment ...
4 years, 9 months ago (2016-03-23 03:44:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823353003/20001
4 years, 9 months ago (2016-03-23 03:45:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 04:32:12 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/27c25394291c192a6a10a83f2bae1c1539feb993 Cr-Commit-Position: refs/heads/master@{#382791}
4 years, 9 months ago (2016-03-23 04:33:37 UTC) #9
chrishtr
4 years, 9 months ago (2016-03-23 16:26:31 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/1823353003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right):

https://codereview.chromium.org/1823353003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:43: // will do a full
paintInvalidationForWholeLayoutObject().
On 2016/03/23 at 03:44:56, Xianzhu wrote:
> The comment above refer to methods that no longer exist. According to it, we
seem to do a full paint invalidation after the style sheets are loaded. I think
it's worth investigating which current methods the comments are supposed to
refer to and if the invalidation really happens and works and why if not. Could
you file a bug and add a TODO here?

Will send you a CL now to fix the comment.

Powered by Google App Engine
This is Rietveld 408576698