Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1823333005: Fixing invalid asm.js in asm-wasm-literals.js (Closed)

Created:
4 years, 9 months ago by bradnelson
Modified:
4 years, 9 months ago
Reviewers:
titzer, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixing invalid asm.js in asm-wasm-literals.js This was previously undetected due to a now fixed typing bug. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=test-asm-validator,asm-wasm TBR=titzer@chromium.org LOG=N NOTRY=true Committed: https://crrev.com/b224651b73747efdfd26ffdc4d5e2fd9efc4e568 Cr-Commit-Position: refs/heads/master@{#35048}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M test/mjsunit/wasm/asm-wasm-literals.js View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823333005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823333005/1
4 years, 9 months ago (2016-03-23 23:52:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823333005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823333005/1
4 years, 9 months ago (2016-03-23 23:57:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 23:59:40 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 00:00:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b224651b73747efdfd26ffdc4d5e2fd9efc4e568
Cr-Commit-Position: refs/heads/master@{#35048}

Powered by Google App Engine
This is Rietveld 408576698