Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1823333003: [Password Manager] Human readable origins for blacklisted Android credentials (Closed)

Created:
4 years, 9 months ago by kolos1
Modified:
4 years, 8 months ago
Reviewers:
vabr (Chromium), engedy
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@android_credentials
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Human readable origins for blacklisted Android credentials Complements this CL (https://codereview.chromium.org/1615653005/) with implementation of human readable origins for blacklisted logins. Uses the same logic as the mentioned CL. BUG=593341 Committed: https://crrev.com/9143cf6049ea20c8dabe0e2481b459f0f3fffa50 Cr-Commit-Position: refs/heads/master@{#384255}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -38 lines) Patch
M chrome/browser/ui/passwords/password_manager_presenter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_store.h View 2 chunks +10 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store_unittest.cc View 2 chunks +50 lines, -37 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
kolos1
Hi Balazs, Please have a look on this CL for blacklisted Android credentials. It is ...
4 years, 9 months ago (2016-03-24 09:45:17 UTC) #3
engedy
LGTM without comments, thank you!
4 years, 9 months ago (2016-03-24 12:03:00 UTC) #4
kolos1
vabr@chromium.org: Please review tiny change in password_manager_presenter.cc.
4 years, 8 months ago (2016-03-29 12:56:27 UTC) #7
vabr (Chromium)
lgtm
4 years, 8 months ago (2016-03-29 13:13:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823333003/20001
4 years, 8 months ago (2016-03-31 11:46:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-03-31 12:33:47 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 12:34:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9143cf6049ea20c8dabe0e2481b459f0f3fffa50
Cr-Commit-Position: refs/heads/master@{#384255}

Powered by Google App Engine
This is Rietveld 408576698