Issue 18233024: Use toSVGFilterElement instead of static_cast<..>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18233024: Use toSVGFilterElement instead of static_cast<..> (Closed)

Created:
7 years, 5 months ago by gyuyoung-inactive

Modified:
7 years, 5 months ago

Reviewers:
tkent

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Use toSVGFilterElement instead of static_cast<..> Though there is toSVGFilterElement(), some files still use static_cast<SVGFilterElement*>. To remove all static_cast<> use, we need to change argument from SVGElement to Node. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154191

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	Source/core/rendering/svg/RenderSVGResourceFilter.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResourceFilter.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/rendering/svg/SVGResources.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGFilterElement.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/18233024/1

7 years, 5 months ago (2013-07-14 12:36:26 UTC) #3

Message was sent while issue was closed.

Change committed as 154191

Expand Messages | Collapse Messages