Abstract PPAPI's ImageData behind webrtc::DesktopFrame interface

remoting/remoting.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
 
     'variables': {
       'conditions': [
@@ skipping 2370 matching lines @@
     },  # end of target 'remoting_host_logging'
 
     {
       'target_name': 'remoting_client',
       'type': 'static_library',
       'variables': { 'enable_wexit_time_destructors': 1, },
       'dependencies': [
         'remoting_base',
         'remoting_jingle_glue',
         'remoting_protocol',
+        '../third_party/webrtc/modules/modules.gyp:desktop_capture',
       ],
       'sources': [
         'client/audio_decode_scheduler.cc',
         'client/audio_decode_scheduler.h',
         'client/audio_player.cc',
         'client/audio_player.h',
         'client/chromoting_client.cc',
         'client/chromoting_client.h',
         'client/chromoting_stats.cc',
         'client/chromoting_stats.h',
@@ skipping 327 matching lines @@
               '-lrpcrt4.lib',
               '-lwtsapi32.lib',
             ],
           },
         }],
         ['OS=="mac" or (OS=="linux" and chromeos==0)', {
           # Javascript unittests are disabled on CrOS because they cause
           # valgrind and test errors.
           #
           # Javascript unittests are disabled on Windows because they add a
-          # dependency on 'common_constants' which (only on Windows) requires
-          # additional dependencies:
+          # dependency on 'common_constants' which (only on Windows) requires
+          # additional dependencies:
           #   '../content/content.gyp:content_common',
           #   'installer_util',
-          # These targets are defined in .gypi files that would need to be
-          # included here:
+          # These targets are defined in .gypi files that would need to be
+          # included here:
           #   '../chrome/chrome_common.gypi',
           #   '../chrome/chrome_installer.gypi',
           #   '../chrome/chrome_installer_util.gypi',
-          # But we can't do that because ninja will complain about multiple
-          # target definitions.
-          # TODO(garykac): Move installer_util into a proper .gyp file so that
-          # it can be included in multiple .gyp files.
+          # But we can't do that because ninja will complain about multiple
+          # target definitions.
+          # TODO(garykac): Move installer_util into a proper .gyp file so that
+          # it can be included in multiple .gyp files.

[Wez, 2013/07/03 23:43:48]

What's happened here? Is Reitveld going nuts?

           'includes': [
             '../chrome/js_unittest_rules.gypi',
           ],
           'dependencies': [
             '../chrome/common_constants.gyp:common_constants',
             '../v8/tools/gyp/v8.gyp:v8',
           ],
           'sources': [
             '../chrome/test/base/v8_unit_test.cc',
             '../chrome/test/base/v8_unit_test.h',
@@ skipping 28 matching lines @@
                   '../base/allocator/allocator.gyp:allocator',
                 ],
               },
             ],
           ],
         }],  # end of 'toolkit_uses_gtk == 1'
       ],  # end of 'conditions'
     },  # end of target 'remoting_unittests'
   ],  # end of targets
 }