Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1823283003: Fix flakiness in PopupMenu tests (Closed)

Created:
4 years, 9 months ago by kenrb
Modified:
4 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flakiness in PopupMenu tests SitePerProcessBrowserTest.PopupMenuTest has some observed flakiness, apparently due to raciness in element repositioning from the change of layout size caused by calling RenderWidgetHostView::SetBounds. The call isn't necessary for the test, so this CL removes it. BUG=597111 Committed: https://crrev.com/634475dac7690a19874d410536beeb6272d6ce8f Cr-Commit-Position: refs/heads/master@{#382897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/browser/site_per_process_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kenrb
Nasko: PTAL? Very small patch to (I think) fix test flakiness.
4 years, 9 months ago (2016-03-23 17:59:41 UTC) #2
nasko
LGTM
4 years, 9 months ago (2016-03-23 18:03:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823283003/1
4 years, 9 months ago (2016-03-23 19:19:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 19:25:21 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 19:26:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/634475dac7690a19874d410536beeb6272d6ce8f
Cr-Commit-Position: refs/heads/master@{#382897}

Powered by Google App Engine
This is Rietveld 408576698